You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by stigsb <gi...@git.apache.org> on 2015/07/24 02:01:54 UTC

[GitHub] thrift pull request: PHP Compiler: always cast scalar types in jso...

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/560

    PHP Compiler: always cast scalar types in jsonSerialize()

    In PHP, values from databases and such are usually always strings, so it is useful to cast values during JSON serialization to maintain the Thrift schema's types.
    
    THRIFT-3263

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift php_jsonserialize_casting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #560
    
----
commit 178953910c18d36ebf16daaa3497123cec77b022
Author: Stig Bakken <st...@zedge.net>
Date:   2015-07-23T23:41:33Z

    PHP Compiler: always cast scalar types in jsonSerialize()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #560: THRIFT-3263: PHP Compiler always casts scalar type...

Posted by jfarrell <gi...@git.apache.org>.

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/560


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #560: THRIFT-3263: PHP Compiler always casts scalar types in js...

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/560
  
    @jfarrell this can be closed.  It was merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---