You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2021/08/24 18:40:41 UTC
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17809
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
impala-profile-tool can display v2 runtime profile (dense format) in
varying verbosity level. In extended verbosity, it should print
individual SummaryStatsCounter from each fragment instances. Instead, it
was repeating the same aggregated stats for each fragment instances.
This patch fix the bug by printing the correct individual
SummaryStatsCounter.
Testing:
- Fix and pass observability/test_profile_tool.py.
- Manually verify that impala-profile-tool print different summary stats
for each fragment instances.
Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
3 files changed, 577 insertions(+), 577 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/17809/1
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17809 )
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
impala-profile-tool can display v2 runtime profile (dense format) in
varying verbosity level. In extended verbosity, it should print
individual SummaryStatsCounter from each fragment instances. Instead, it
was repeating the same aggregated stats for each fragment instances.
This patch fix the bug by printing the correct individual
SummaryStatsCounter.
Testing:
- Fix and pass observability/test_profile_tool.py.
- Manually verify that impala-profile-tool print different summary stats
for each fragment instances.
Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Reviewed-on: http://gerrit.cloudera.org:8080/17809
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.txt
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
3 files changed, 577 insertions(+), 577 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17809 )
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7431/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Aug 2021 20:15:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17809 )
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sat, 28 Aug 2021 02:22:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17809 )
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
Patch Set 1: Code-Review+2
Thanks for tracking this down, this looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 23:20:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17809 )
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Aug 2021 20:15:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17809 )
Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9361/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3b9127bf98f2168eca6b42375d3a8e85c2cffb
Gerrit-Change-Number: 17809
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 19:01:57 +0000
Gerrit-HasComments: No