[GitHub] [camel-spring-boot-examples] oscerd commented on a change in pull request #19: Load Balancer EIP example

[GitBox <gi...@apache.org>]

oscerd commented on a change in pull request #19:
URL: https://github.com/apache/camel-spring-boot-examples/pull/19#discussion_r512724547



##########
File path: camel-example-spring-boot-load-balancer-eip/src/main/java/sample/camel/CustomLoadBalancer.java
##########
@@ -0,0 +1,23 @@
+package sample.camel;

Review comment:
       Please use org.apache.camel.springboot.example as package

##########
File path: camel-example-spring-boot-load-balancer-eip/README.adoc
##########
@@ -0,0 +1,31 @@
+== Camel Example Spring Boot
+
+This example shows several examples of Load Balancer EIP with Apache Camel application using Spring Boot.
+
+1. Round-robin - The exchanges are selected from in a round robin fashion. This is a well known and classic policy, which spreads the load evenly.

Review comment:
       I think it should be only "in" and not "from in"

##########
File path: camel-example-spring-boot-load-balancer-eip/src/main/java/sample/camel/LoadBalancerEIPRouter.java
##########
@@ -0,0 +1,120 @@
+package sample.camel;

Review comment:
       License is missing and please use the package org.apache.camel.springboot.example

##########
File path: camel-example-spring-boot-load-balancer-eip/pom.xml
##########
@@ -0,0 +1,130 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       License is missing

##########
File path: camel-example-spring-boot-load-balancer-eip/src/main/java/sample/camel/MyException.java
##########
@@ -0,0 +1,11 @@
+package sample.camel;

Review comment:
       Ditto

##########
File path: camel-example-spring-boot-load-balancer-eip/src/test/java/LoadBalancerEIPTest.java
##########
@@ -0,0 +1,170 @@
+package com.fg7;

Review comment:
       Please use org.apache.camel.springboot.example and license is missing

##########
File path: camel-example-spring-boot-load-balancer-eip/src/main/java/sample/camel/CustomLoadBalancer.java
##########
@@ -0,0 +1,23 @@
+package sample.camel;

Review comment:
       License is missing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org