You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/30 21:11:11 UTC

[GitHub] zhaoyao73 opened a new pull request #13496: Optimize C++ API

zhaoyao73 opened a new pull request #13496: Optimize C++ API
URL: https://github.com/apache/incubator-mxnet/pull/13496
 
 
   Pass parameter with reference instead of value.
   Add const as well as it is not changed.
   
   ## Description ##
   Optimize some functions to pass reference instead of value. This could avoid unnecessary construction/destruction and copy.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   -  tiny changes
   - did a successful build
   - For user-facing API changes, API doc string has been updated. 
     Didn't find the API doc in mxnet.io/doxygen
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   
   ## Comments ##
   I am not sure I could run a sanity test with it or how to run a unit test/sanity test against the change. But pass value -> pass reference, should be transparent to C++, although not like C's pass value->pass pointer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services