You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Christoffer Eide (JIRA)" <ji...@apache.org> on 2016/06/13 09:51:21 UTC
[jira] [Closed] (HTTPCLIENT-1747) The "default request config"
socket timeout is set to 0 if the deprecated HttpClientParams is used
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christoffer Eide closed HTTPCLIENT-1747.
----------------------------------------
Resolution: Fixed
Looks good. Thanks! :)
> The "default request config" socket timeout is set to 0 if the deprecated HttpClientParams is used
> --------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1747
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1747
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.5.2
> Reporter: Christoffer Eide
> Priority: Minor
> Fix For: 4.5.3
>
>
> We have some legacy library code that uses the http client.
> We pass in a well configured http client (with connection and socket timeouts) to the library.
> The library calls the deprecated {{org.apache.http.client.params.HttpClientParams}}. This causes the timeouts to be set to 0 when the clients tries to connect to a socket.
> The library calls:
> {{HttpClientParams.setRedirecting(get.getParams(), true);}}
> This makes the {{org.apache.http.impl.client.InternalHttpClient#doExecute}} call {{HttpClientParamConfig.getRequestConfig(params)}}. If {{HttpClientParamConfig}} does not find a value for the timeouts in {{params}}, it defaults to {{0}}. Perhaps it should get those default values from the configured default request config?
> There is a junit test that demonstrates the behaviour:
> {code:lang=java}
> import org.apache.http.HttpHost;
> import org.apache.http.client.config.RequestConfig;
> import org.apache.http.client.methods.CloseableHttpResponse;
> import org.apache.http.client.methods.HttpGet;
> import org.apache.http.client.params.HttpClientParams;
> import org.apache.http.config.SocketConfig;
> import org.apache.http.conn.socket.LayeredConnectionSocketFactory;
> import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
> import org.apache.http.impl.client.CloseableHttpClient;
> import org.apache.http.impl.client.HttpClientBuilder;
> import org.apache.http.protocol.HttpContext;
> import org.junit.After;
> import org.junit.Before;
> import org.junit.Test;
> import java.io.IOException;
> import java.net.InetSocketAddress;
> import java.net.Socket;
> import java.net.UnknownHostException;
> import static org.junit.Assert.assertEquals;
> public final class HttpClientTest {
> CloseableHttpClient client;
> @Before
> public void setUp() throws Exception {
> final int timeout = 100;
> SocketConfig socketConfig = SocketConfig.custom()
> .setSoTimeout(timeout)
> .build();
> RequestConfig requestConfig = RequestConfig.custom()
> .setConnectionRequestTimeout(timeout)
> .setConnectTimeout(timeout)
> .setSocketTimeout(timeout)
> .build();
> client = HttpClientBuilder.create()
> .setDefaultSocketConfig(socketConfig)
> .setDefaultRequestConfig(requestConfig)
> .setSSLSocketFactory(new LayeredConnectionSocketFactory() {
> @Override
> public Socket createLayeredSocket(Socket socket, String target, int port, HttpContext context) throws IOException, UnknownHostException {
> return SSLConnectionSocketFactory.getSystemSocketFactory()
> .createLayeredSocket(socket, target, port, context);
> }
> @Override
> public Socket createSocket(HttpContext context) throws IOException {
> return SSLConnectionSocketFactory.getSystemSocketFactory()
> .createSocket(context);
> }
> @Override
> public Socket connectSocket(int connectTimeout, Socket sock, HttpHost host, InetSocketAddress remoteAddress, InetSocketAddress localAddress, HttpContext context) throws IOException {
> assertEquals(connectTimeout, timeout);
> throw new RuntimeException("expected");
> }
> })
> .build();
> }
> @After
> public void tearDown() throws Exception {
> client.close();
> }
> @Test(expected = RuntimeException.class)
> public void timeoutsIsCleared() throws Exception {
> HttpGet get = new HttpGet("https://google.com");
> HttpClientParams.setRedirecting(get.getParams(), true);
> try(CloseableHttpResponse response = client.execute(get)){
> }
> }
> @Test(expected = RuntimeException.class)
> public void timeoutsIsRetained() throws Exception {
> HttpGet get = new HttpGet("https://google.com");
> try(CloseableHttpResponse response = client.execute(get)){
>
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org