You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/04/18 19:04:06 UTC

git commit: SPARK-1357 (addendum). More Experimental items in MLlib

Repository: spark
Updated Branches:
  refs/heads/master aa17f022c -> 8aa1f4c4f


SPARK-1357 (addendum). More Experimental items in MLlib

Per discussion, this is my suggestion to make ALS Rating, ClassificationModel, RegressionModel experimental for now, to reserve the right to possibly change after 1.0. See what you think of this much.

Author: Sean Owen <so...@cloudera.com>

Closes #372 from srowen/SPARK-1357Addendum and squashes the following commits:

17cf1ea [Sean Owen] Remove (another) blank line after ":: Experimental ::"
6800e4c [Sean Owen] Remove blank line after ":: Experimental ::"
b3a88d2 [Sean Owen] Make ALS Rating, ClassificationModel, RegressionModel experimental for now, to reserve the right to possibly change after 1.0


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/8aa1f4c4
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/8aa1f4c4
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/8aa1f4c4

Branch: refs/heads/master
Commit: 8aa1f4c4f6d60168737699b5a9eafd6a05660976
Parents: aa17f02
Author: Sean Owen <so...@cloudera.com>
Authored: Fri Apr 18 10:04:02 2014 -0700
Committer: Reynold Xin <rx...@apache.org>
Committed: Fri Apr 18 10:04:02 2014 -0700

----------------------------------------------------------------------
 .../apache/spark/mllib/classification/ClassificationModel.scala | 3 +++
 .../main/scala/org/apache/spark/mllib/recommendation/ALS.scala  | 2 ++
 .../org/apache/spark/mllib/regression/RegressionModel.scala     | 5 +++++
 3 files changed, 10 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/8aa1f4c4/mllib/src/main/scala/org/apache/spark/mllib/classification/ClassificationModel.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/classification/ClassificationModel.scala b/mllib/src/main/scala/org/apache/spark/mllib/classification/ClassificationModel.scala
index bd10e2e..6332301 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/classification/ClassificationModel.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/classification/ClassificationModel.scala
@@ -19,11 +19,14 @@ package org.apache.spark.mllib.classification
 
 import org.apache.spark.mllib.linalg.Vector
 import org.apache.spark.rdd.RDD
+import org.apache.spark.annotation.Experimental
 
 /**
+ * :: Experimental ::
  * Represents a classification model that predicts to which of a set of categories an example
  * belongs. The categories are represented by double values: 0.0, 1.0, 2.0, etc.
  */
+@Experimental
 trait ClassificationModel extends Serializable {
   /**
    * Predict values for the given data set using the model trained.

http://git-wip-us.apache.org/repos/asf/spark/blob/8aa1f4c4/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala
index 5cc47de..102742c 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala
@@ -56,8 +56,10 @@ private[recommendation] case class InLinkBlock(
 
 
 /**
+ * :: Experimental ::
  * A more compact class to represent a rating than Tuple3[Int, Int, Double].
  */
+@Experimental
 case class Rating(val user: Int, val product: Int, val rating: Double)
 
 /**

http://git-wip-us.apache.org/repos/asf/spark/blob/8aa1f4c4/mllib/src/main/scala/org/apache/spark/mllib/regression/RegressionModel.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/regression/RegressionModel.scala b/mllib/src/main/scala/org/apache/spark/mllib/regression/RegressionModel.scala
index 5e4b8a3..027305a 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/regression/RegressionModel.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/regression/RegressionModel.scala
@@ -19,7 +19,12 @@ package org.apache.spark.mllib.regression
 
 import org.apache.spark.rdd.RDD
 import org.apache.spark.mllib.linalg.Vector
+import org.apache.spark.annotation.Experimental
 
+/**
+ * :: Experimental ::
+ */
+@Experimental
 trait RegressionModel extends Serializable {
   /**
    * Predict values for the given data set using the model trained.