[GitHub] [ozone] adoroszlai commented on a diff in pull request #3997: HDDS-7450. Improve bucket creation message

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #3997:
URL: https://github.com/apache/ozone/pull/3997#discussion_r1094124603


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -687,13 +687,21 @@ public void createBucket(
       builder.setDefaultReplicationConfig(defaultReplicationConfig);
     }
 
+    String replicationType = defaultReplicationConfig == null 
+        ? "with server-side default replication type"

Review Comment:
   I think this `with` is unnecessary, as the message would look like: `Replication Type set to with server-side default replication type`.
   
   ```suggestion
           ? "server-side default replication type"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org