You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/16 03:33:06 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

xiaoxiang781216 opened a new pull request, #7324:
URL: https://github.com/apache/incubator-nuttx/pull/7324

   ## Summary
   Remove the duplication
   
   ## Impact
   code refactor only
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7324:
URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279975243

   Fix all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7324:
URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279961190

   > ```
   > Error: nor_main.c:78:5: error: conflicting types for 'nor_main'
   >    78 | int nor_main(int argc, char *argv)
   >       |     ^~~~~~~~
   > In file included from nor_main.c:25:
   > /github/workspace/sources/nuttx/include/sys/types.h:318:5: note: previous declaration of 'nor_main' was here
   >   318 | int CONFIG_INIT_ENTRYPOINT(int argc, FAR char *argv[]);
   > ```
   
   Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7324:
URL: https://github.com/apache/incubator-nuttx/pull/7324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7324:
URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279934225

   ```
   Error: nor_main.c:78:5: error: conflicting types for 'nor_main'
      78 | int nor_main(int argc, char *argv)
         |     ^~~~~~~~
   In file included from nor_main.c:25:
   /github/workspace/sources/nuttx/include/sys/types.h:318:5: note: previous declaration of 'nor_main' was here
     318 | int CONFIG_INIT_ENTRYPOINT(int argc, FAR char *argv[]);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7324:
URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279974523

   Same with `dram_main.c:76:5: error: conflicting types for 'dram_main'`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org