[jira] Commented: (OFBIZ-1101) Missing Billing Accounts in Dropdown

["Guido Amarilla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507876 ] 

Guido Amarilla commented on OFBIZ-1101:
---------------------------------------

The code that generates the list, uses accountAvailable as a key (accountAvailable = accountLimit - accountBalance) , so if the value repeats in more than one billing accounts, it is overwritten, and only the last one is added to the list.

in BillingAccountWorker.java line 100:

billingAccount.put("accountBalance", new Double(accountBalance)); 
double accountAvailable = accountLimit - accountBalance;
totalAvailable += accountAvailable;    
sortedAccounts.put(new Double(accountAvailable), billingAccount);

....

billingAccountList.addAll(sortedAccounts.values());

.....

return billingAccountList;



> Missing Billing Accounts in Dropdown
> ------------------------------------
>
>                 Key: OFBIZ-1101
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1101
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Priority: Minor
>
> The dropdown list for billing account selection in Order payment method selection  is not populated with all the billing accounts for the customer. There are missing billing accounts in the selection dropdown.
> I think this happens when the available value in the accounts is the same for two or more billing accounts of the same party.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.