You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Robert Hu (JIRA)" <ji...@apache.org> on 2006/11/09 10:58:37 UTC
[jira] Created: (HARMONY-2122) [classlib][luni] Calendar
incorrectly handle new AM_PM value setting
[classlib][luni] Calendar incorrectly handle new AM_PM value setting
--------------------------------------------------------------------
Key: HARMONY-2122
URL: http://issues.apache.org/jira/browse/HARMONY-2122
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Robert Hu
Priority: Minor
Following code is to test whether the Calendar.set(int,int) method successfully set the new value of AM_PM.
Calendar cal = Calendar.getInstance();
int oldValue = cal.get(Calendar.AM_PM);
int newValue = (oldValue == Calendar.AM)?Calendar.PM:Calendar.AM;
cal.set(Calendar.AM_PM, newValue);
newValue = cal.get(Calendar.AM_PM);
assertTrue(newValue!=oldValue);
RI passes it
Harmony failed it.
The problem is maybe in the complete() method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2122) [classlib][luni] Calendar
incorrectly handle new AM_PM value setting
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2122?page=all ]
Paulex Yang reassigned HARMONY-2122:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni] Calendar incorrectly handle new AM_PM value setting
> --------------------------------------------------------------------
>
> Key: HARMONY-2122
> URL: http://issues.apache.org/jira/browse/HARMONY-2122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Robert Hu
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony2122.diff
>
>
> Following code is to test whether the Calendar.set(int,int) method successfully set the new value of AM_PM.
>
> Calendar cal = Calendar.getInstance();
> int oldValue = cal.get(Calendar.AM_PM);
> int newValue = (oldValue == Calendar.AM)?Calendar.PM:Calendar.AM;
> cal.set(Calendar.AM_PM, newValue);
> newValue = cal.get(Calendar.AM_PM);
> assertTrue(newValue!=oldValue);
> RI passes it
> Harmony failed it.
> The problem is maybe in the complete() method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2122) [classlib][luni] Calendar
incorrectly handle new AM_PM value setting
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2122?page=comments#action_12448420 ]
Jimmy, Jing Lv commented on HARMONY-2122:
-----------------------------------------
This may be a bug of set, seems it should set lastTimeFieldSet when setting AM_PM. I'll take a look.
> [classlib][luni] Calendar incorrectly handle new AM_PM value setting
> --------------------------------------------------------------------
>
> Key: HARMONY-2122
> URL: http://issues.apache.org/jira/browse/HARMONY-2122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Robert Hu
> Priority: Minor
>
> Following code is to test whether the Calendar.set(int,int) method successfully set the new value of AM_PM.
>
> Calendar cal = Calendar.getInstance();
> int oldValue = cal.get(Calendar.AM_PM);
> int newValue = (oldValue == Calendar.AM)?Calendar.PM:Calendar.AM;
> cal.set(Calendar.AM_PM, newValue);
> newValue = cal.get(Calendar.AM_PM);
> assertTrue(newValue!=oldValue);
> RI passes it
> Harmony failed it.
> The problem is maybe in the complete() method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2122) [classlib][luni] Calendar
incorrectly handle new AM_PM value setting
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2122?page=all ]
Paulex Yang resolved HARMONY-2122.
----------------------------------
Resolution: Fixed
Jimmy, patch applied at revision r475335, thanks a lot for this enhancement.
Robert, please verify the problem is fully resolved, thank you.
> [classlib][luni] Calendar incorrectly handle new AM_PM value setting
> --------------------------------------------------------------------
>
> Key: HARMONY-2122
> URL: http://issues.apache.org/jira/browse/HARMONY-2122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Robert Hu
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony2122.diff
>
>
> Following code is to test whether the Calendar.set(int,int) method successfully set the new value of AM_PM.
>
> Calendar cal = Calendar.getInstance();
> int oldValue = cal.get(Calendar.AM_PM);
> int newValue = (oldValue == Calendar.AM)?Calendar.PM:Calendar.AM;
> cal.set(Calendar.AM_PM, newValue);
> newValue = cal.get(Calendar.AM_PM);
> assertTrue(newValue!=oldValue);
> RI passes it
> Harmony failed it.
> The problem is maybe in the complete() method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2122) [classlib][luni] Calendar
incorrectly handle new AM_PM value setting
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2122?page=all ]
Jimmy, Jing Lv updated HARMONY-2122:
------------------------------------
Attachment: Harmony2122.diff
Hi,
Would you please try this patch? Thanks!
Best Regards,
Jimmy
> [classlib][luni] Calendar incorrectly handle new AM_PM value setting
> --------------------------------------------------------------------
>
> Key: HARMONY-2122
> URL: http://issues.apache.org/jira/browse/HARMONY-2122
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Robert Hu
> Priority: Minor
> Attachments: Harmony2122.diff
>
>
> Following code is to test whether the Calendar.set(int,int) method successfully set the new value of AM_PM.
>
> Calendar cal = Calendar.getInstance();
> int oldValue = cal.get(Calendar.AM_PM);
> int newValue = (oldValue == Calendar.AM)?Calendar.PM:Calendar.AM;
> cal.set(Calendar.AM_PM, newValue);
> newValue = cal.get(Calendar.AM_PM);
> assertTrue(newValue!=oldValue);
> RI passes it
> Harmony failed it.
> The problem is maybe in the complete() method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira