[GitHub] [buildstream-plugins] gtristan commented on a diff in pull request #19: {git,cargo}: fix set_ref following the latest buildstream changes

[GitBox <gi...@apache.org>]

gtristan commented on code in PR #19:
URL: https://github.com/apache/buildstream-plugins/pull/19#discussion_r934727374


##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -375,7 +375,7 @@ def get_ref(self):
 
     def set_ref(self, ref, node):
         node["ref"] = ref
-        self._recompute_crates(ref)
+        self._recompute_crates(node.get_sequence("ref"))

Review Comment:
   Yes.
   
   After assigning a python `list` object as a member of a `MappingNode`, it will become a `SequenceNode` instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org