You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jadami10 (via GitHub)" <gi...@apache.org> on 2023/03/27 00:22:34 UTC
[GitHub] [pinot] jadami10 opened a new pull request, #10479: wait for full segment commit protocol on force commit
jadami10 opened a new pull request, #10479:
URL: https://github.com/apache/pinot/pull/10479
This closes https://github.com/apache/pinot/issues/10460
This isn't necessarily a bug, but it can lead to unexpected behavior. We observed that picking the first server to respond to force commit led to a case where a server that was several hours behind was chosen as the winner. In the issue, we discussed that the intention was to kick off committing immediately on force commit, but it should generally not be detrimental (extra ~3 seconds) to wait for the typical segment commit protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10479: wait for full segment commit protocol on force commit
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10479:
URL: https://github.com/apache/pinot/pull/10479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on pull request #10479: wait for full segment commit protocol on force commit
Posted by "jadami10 (via GitHub)" <gi...@apache.org>.
jadami10 commented on PR #10479:
URL: https://github.com/apache/pinot/pull/10479#issuecomment-1485886850
@Jackie-Jiang , do you mind rerunning the failed workflows? looks like a flake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10479: wait for full segment commit protocol on force commit
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10479:
URL: https://github.com/apache/pinot/pull/10479#issuecomment-1484335845
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10479](https://codecov.io/gh/apache/pinot/pull/10479?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa1ffc9) into [master](https://codecov.io/gh/apache/pinot/commit/0e6c3860941cf225f10d072eb459f1883ed0a0ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e6c386) will **decrease** coverage by `45.84%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10479 +/- ##
=============================================
- Coverage 70.26% 24.42% -45.84%
+ Complexity 6113 49 -6064
=============================================
Files 2070 2045 -25
Lines 111951 111171 -780
Branches 17051 16957 -94
=============================================
- Hits 78658 27152 -51506
- Misses 27746 81202 +53456
+ Partials 5547 2817 -2730
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.42% <0.00%> (+0.04%)` | :arrow_up: |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/pinot/pull/10479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `46.43% <0.00%> (-25.72%)` | :arrow_down: |
... and [1540 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10479/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org