You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Timo Walther (JIRA)" <ji...@apache.org> on 2019/02/19 09:51:00 UTC
[jira] [Comment Edited] (FLINK-11067) Convert TableEnvironments to
interfaces
[ https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771773#comment-16771773 ]
Timo Walther edited comment on FLINK-11067 at 2/19/19 9:50 AM:
---------------------------------------------------------------
Thanks for working on this [~hequn8128]. This issue might be blocked on converting {{Table}} to an interface.
Your proposal sounds ok to me. However, I would name {{java.TableEnvironment}} also {{java.BaseTableEnvironment}} or even {{java.JavaTableEnvironment}} to avoid confusion for users. If you find any problems or questions, feel free to ping me early such that we can solve problems immediately.
Btw. why can't we name {{api.BaseTableEnvironment}} to {{api.TableEnvironment}}? In a long-term vision, {{api.TableEnvironment}} will the only environment left. Users won't need language specific environments anymore unless they want to interact with DataStream API.
was (Author: twalthr):
Thanks for working on this [~hequn8128]. This issue might be blocked on converting {{Table}} to an interface.
Your proposal sounds ok to me. However, I would name {{java.TableEnvironment}} also {{java.BaseTableEnvironment}} or even {{java.JavaTableEnvironment}} to avoid confusion for users. If you find any problems or questions, feel free to ping me early such that we can solve problems immediately.
Btw. why can't we name \{{api.BaseTableEnvironment}} to \{{api.TableEnvironment}}? In a long-term vision, \{{api.TableEnvironment}} will the only environment left. Users won't need language specific environments anymore unless they want to interact with DataStream API.
> Convert TableEnvironments to interfaces
> ---------------------------------------
>
> Key: FLINK-11067
> URL: https://issues.apache.org/jira/browse/FLINK-11067
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Hequn Cheng
> Priority: Major
>
> A more detailed description can be found in [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> This task includes porting {{TableEnvironment}}, {{StreamTableEnvironment}}, {{BatchTableEnvironment}} to Java interfaces. API-breaking changes should not be necessary anymore as they should have been resolved by sibling issues. Some refactoring and clean up might be necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)