You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/27 01:47:04 UTC
[GitHub] [kafka] showuon opened a new pull request #10228: KAFKA-10251: increase timeout for consumeing records
showuon opened a new pull request #10228:
URL: https://github.com/apache/kafka/pull/10228
We need to wait for the translation state changed to `READY` to start consuming the records. But we didn't have any way to change the transationManager state in client, so we can just wait. I've confirmed that if we try another time, we can pass the tests. My test code is like this:
```java
var isFailed = false
try {
pollRecordsUntilTrue(consumer, pollAction,
waitTimeMs = waitTimeMs,
msg = s"Consumed ${records.size} records before timeout instead of the expected $numRecords records")
} catch {
case e: AssertionFailedError => {
isFailed = true
System.err.println(s"!!! Consumed ${records.size} records before timeout instead of the expected $numRecords records")
}
}
if (isFailed) {
pollRecordsUntilTrue(consumer, pollAction,
waitTimeMs = 30000,
msg = s"Consumed ${records.size} records before timeout instead of the expected $numRecords records")
// if we go to this step, it means it passed in 2nd try
fail("failed at 1st try")
}
```
And they failed with `failed at 1st try`, which confirmed that we can pass the tests by increasing the timeout. Thanks.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10228: KAFKA-10251: increase timeout for consumeing records
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10228:
URL: https://github.com/apache/kafka/pull/10228#issuecomment-789166076
Since this test is failing pretty regularly, I think we should go ahead and merge this now. A 30s timeout is pretty standard and if there is a real issue, just bumping the timeout from 15s to 30s should not cover it up. We can reopen the ticket if new failures are seen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10228: KAFKA-10251: increase timeout for consumeing records
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10228:
URL: https://github.com/apache/kafka/pull/10228#issuecomment-788534430
@ableegoldman , to investigate this flaky test, I have a drafted PR, to output some debug log on jenkins build. This is what I mentioned in the PR description: `failed at 1st try`
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9724/148/testReport/junit/kafka.api/TransactionsBounceTest/Build___JDK_15___testWithGroupMetadata__/
So, I cannot reproduce it on my local env, instead, I reproduce it on jenkins env.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10228: KAFKA-10251: increase timeout for consumeing records
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10228:
URL: https://github.com/apache/kafka/pull/10228#issuecomment-786981927
@abbccdda @ableegoldman @mjsax , could you help review this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10228: KAFKA-10251: increase timeout for consumeing records
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10228:
URL: https://github.com/apache/kafka/pull/10228#issuecomment-789162142
Three unrelated failures:
```
Build / JDK 15 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining
Build / JDK 15 / kafka.api.AuthorizerIntegrationTest.testFetchFollowerRequest()
Build / JDK 15 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10228: KAFKA-10251: increase timeout for consumeing records
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10228:
URL: https://github.com/apache/kafka/pull/10228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org