[GitHub] [spark] viirya commented on a change in pull request #25133: [SPARK-28365][ML] Fallback locale to en_US in StopWordsRemover if system default locale isn't in available locales in JVM

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #25133: [SPARK-28365][ML] Fallback locale to en_US in StopWordsRemover if system default locale isn't in available locales in JVM
URL: https://github.com/apache/spark/pull/25133#discussion_r303269175
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala
 ##########
 @@ -89,7 +89,8 @@ class StopWordsRemover @Since("1.5.0") (@Since("1.5.0") override val uid: String
   /**
    * Locale of the input for case insensitive matching. Ignored when [[caseSensitive]]
    * is true.
-   * Default: Locale.getDefault.toString
+   * Default: Locale.getDefault.toString, or Locale.US.toString if default locale isn't in
 
 Review comment:
   I think it just follows previous `Locale.getDefault.toString`. Getting rid of toString for both?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org