You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Peter Donald <do...@apache.org> on 2001/10/15 07:57:08 UTC
[PATCH] [torque] JLS compliance
Hi,
The attached patch cleans up the codebase so it compiles under pedantic mode
in jikes. There was several places where redundent access specifiers were
placed. This is "strongly discouraged" by the JLS and this patch just
rectifies this.
--
Cheers,
Pete
------------------------------------------------------------
militant agnostic: i don't know, and you don't know either.
------------------------------------------------------------
Re: [PATCH] [torque] JLS compliance
Posted by John McNally <jm...@collab.net>.
It appears the jls only strongly discourages the use of redundant
modifiers on methods. It says it is okay to use them on fields. But no
reason to use them one place and not another. I applied your patch,
though it appears the file had some extra contol chars or something.
john mcnally
Peter Donald wrote:
>
> Hi,
>
> The attached patch cleans up the codebase so it compiles under pedantic mode
> in jikes. There was several places where redundent access specifiers were
> placed. This is "strongly discouraged" by the JLS and this patch just
> rectifies this.
>
> --
> Cheers,
>
> Pete
>
> ------------------------------------------------------------
> militant agnostic: i don't know, and you don't know either.
> ------------------------------------------------------------
>
> ------------------------------------------------------------------------
> Name: jls.diff
> jls.diff Type: text/x-diff
> Encoding: base64
>
> ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org