You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by lr...@apache.org on 2009/10/22 03:39:40 UTC
svn commit: r828276 -
/tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java
Author: lresende
Date: Thu Oct 22 01:39:39 2009
New Revision: 828276
URL: http://svn.apache.org/viewvc?rev=828276&view=rev
Log:
TUSCANY-3294 - Adding check in the runtime to validate JCA100006, that states that JAX-WS client-side asynchronous pooling and callback methods are not allowed in service interface
Modified:
tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java
Modified: tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java?rev=828276&r1=828275&r2=828276&view=diff
==============================================================================
--- tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java (original)
+++ tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java Thu Oct 22 01:39:39 2009
@@ -19,6 +19,8 @@
package org.apache.tuscany.sca.builder.impl;
+import java.util.List;
+
import org.apache.tuscany.sca.assembly.AssemblyFactory;
import org.apache.tuscany.sca.assembly.Binding;
import org.apache.tuscany.sca.assembly.Component;
@@ -31,6 +33,8 @@
import org.apache.tuscany.sca.assembly.builder.CompositeBuilderException;
import org.apache.tuscany.sca.core.ExtensionPointRegistry;
import org.apache.tuscany.sca.core.FactoryExtensionPoint;
+import org.apache.tuscany.sca.interfacedef.Operation;
+import org.apache.tuscany.sca.monitor.Monitor;
/**
* creates endpoint models for component services.
@@ -50,26 +54,57 @@
* @param definitions
* @param monitor - a Monitor for logging errors
*/
- public Composite build(Composite composite, BuilderContext context)
- throws CompositeBuilderException {
+ public Composite build(Composite composite, BuilderContext context) throws CompositeBuilderException {
- processComponentServices(composite);
+ processComponentServices(composite, context);
return composite;
- } // end method build
+ }
- private void processComponentServices(Composite composite) {
+ private void processComponentServices(Composite composite, BuilderContext context) {
+ Monitor monitor = context.getMonitor();
+
for (Component component : composite.getComponents()) {
+ monitor.pushContext("Component: " + component.getName().toString());
+
// recurse for composite implementations
Implementation implementation = component.getImplementation();
if (implementation instanceof Composite) {
- processComponentServices((Composite)implementation);
+ processComponentServices((Composite)implementation, context);
}
// create an endpoint for each component service binding
for (ComponentService service : component.getServices()) {
+ monitor.pushContext("Service: " + service.getName());
+
+ //verify JAX-WS async assertions as in JavaCAA section 11.1
+ List<Operation> asyncOperations = null;
+ try {
+ asyncOperations = (List<Operation>) service.getInterfaceContract().getInterface().getAttributes().get("JAXWS-ASYNC-OPERATIONS");
+ }catch(Exception e) {
+ //ignore
+ }
+
+
+ if(asyncOperations != null) {
+ if( ! asyncOperations.isEmpty()) {
+
+ //error JCA100006
+
+ //FIXME create a java validation message resource bundle
+ Monitor.error(monitor,
+ this,
+ null,
+ "[JCA100006] JAX-WS client-side asynchronous pooling and callback methods are not allowed in service interfaces",
+ service,
+ service.getName());
+ }
+ }
+
+
+
/* change to finding the promoted component and service
* when the wire is created as storing them here leads to
Re: svn commit: r828276 - /tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java
Posted by Luciano Resende <lu...@gmail.com>.
On Thu, Oct 22, 2009 at 6:51 AM, Simon Laws <si...@googlemail.com> wrote:
> need some monitor.popContext() calls to match the pushContext() calls.
> Am adding them now.
>
> Simon
>
Thanks.
--
Luciano Resende
http://people.apache.org/~lresende
http://lresende.blogspot.com/
Re: svn commit: r828276 - /tuscany/java/sca/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/EndpointBuilderImpl.java
Posted by Simon Laws <si...@googlemail.com>.
need some monitor.popContext() calls to match the pushContext() calls.
Am adding them now.
Simon