You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Matt Juntunen (Jira)" <ji...@apache.org> on 2020/01/16 03:47:00 UTC
[jira] [Commented] (GEOMETRY-85) Enclosing API Updates
[ https://issues.apache.org/jira/browse/GEOMETRY-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016523#comment-17016523 ]
Matt Juntunen commented on GEOMETRY-85:
---------------------------------------
PR is in: https://github.com/apache/commons-geometry/pull/56
> Enclosing API Updates
> ---------------------
>
> Key: GEOMETRY-85
> URL: https://issues.apache.org/jira/browse/GEOMETRY-85
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The API for the enclosing module should be updated for consistency with the rest of the library.
> * {{EnclosingBall}}
> ** {{getSupport}} should return list of points instead of array
> ** {{contains(P pt, double margin)}} should be changed to accept a {{DoublePrecisionContext}} as the second argument.
> * Add {{WelzelEncloser2D}} and {{WelzlEncloser3D}} convenience classes so that that users do not need to construct a generic {{WelzelEncloser}} object and supply their own {{SupportBallGenerator}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)