[GitHub] [apisix] moonming commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

[GitBox <gi...@apache.org>]

moonming commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r487604738



##########
File path: t/admin/schema.t
##########
@@ -40,7 +40,7 @@ qr/"plugins":\{"type":"object"}/
 --- request
 GET /apisix/admin/schema/service
 --- response_body eval
-qr/"required":\["upstream"\]/
+qr/"required".*additionalProperties/

Review comment:
       why change this line?

##########
File path: t/admin/services.t
##########
@@ -1085,3 +1085,50 @@ GET /t
 --- error_code: 400
 --- no_error_log
 [error]
+
+
+
+=== TEST 31: set service(id: 1)（allow empty `service` object）

Review comment:
       Insufficient test cases, can I add content in the empty object later?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org