[GitHub] haojin2 commented on a change in pull request #10135: [MXNET-100] Fix buggy type inference in Correlation

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #10135: [MXNET-100] Fix buggy type inference in Correlation
URL: https://github.com/apache/incubator-mxnet/pull/10135#discussion_r175217818
 
 

 ##########
 File path: src/operator/correlation-inl.h
 ##########
 @@ -232,10 +232,10 @@ void Init(const std::vector<std::pair<std::string, std::string> >& kwargs) overr
                  std::vector<int> *out_type,
                  std::vector<int> *aux_type) const override {
     int dtype = (*in_type)[0];
-    type_assign(&(*in_type)[1], dtype);
-    type_assign(&(*out_type)[0], dtype);
-    type_assign(&(*out_type)[1], dtype);
-    type_assign(&(*out_type)[2], dtype);
+    type_assign(&dtype, (*in_type)[1]);
 
 Review comment:
   This function does not have attrs argument, I guess what we have here is the only way to go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services