[jira] [Commented] (SQOOP-3090) Normalize test cases where expect an exception

["Attila Szabo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770053#comment-15770053 ] 

Attila Szabo commented on SQOOP-3090:
-------------------------------------

Hey [~BoglarkaEgyed],

Could you give a bit more detail around what would you like to do with the test cases/test classes?
Do you have a rough estimate how many tests would be effected by this change?
Can you tell me when you'd like to start work on this? 

Thanks for the feedbacks,
[~maugli]

> Normalize test cases where expect an exception
> ----------------------------------------------
>
>                 Key: SQOOP-3090
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3090
>             Project: Sqoop
>          Issue Type: Improvement
>    Affects Versions: 1.4.6
>            Reporter: Boglarka Egyed
>            Assignee: Boglarka Egyed
>            Priority: Minor
>
> Many test cases uses the following logic to test if an exception has been thrown:
> {code:java}
> try {
>       <do something>
>       fail("Expected exception");
>     } catch (someException e) {
>       // expected
>     }
>   }
> {code}
> This form is not self-explanatory enough and could be replaced by a one line ExpectedException check which would be more clean.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)