You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/12/11 19:11:35 UTC
Re: Review Request 39622: CMake: Pointed Stout test linker flags at
correct gtest directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39622/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 6:11 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Pointed Stout test linker flags at correct gtest directory.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 9893d741cd7c611dc65eba76be03e06dac618132
Diff: https://reviews.apache.org/r/39622/diff/
Testing
-------
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Re: Review Request 39622: CMake: Pointed Stout test linker flags at
correct gtest directory.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39622/#review110100
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 11, 2015, 6:11 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39622/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 6:11 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Pointed Stout test linker flags at correct gtest directory.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 9893d741cd7c611dc65eba76be03e06dac618132
>
> Diff: https://reviews.apache.org/r/39622/diff/
>
>
> Testing
> -------
>
> `make check` from CMake on OS X 10.10.
> `make check` from Autotools on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
> PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
>
>
> Thanks,
>
> Alex Clemmer
>
>