Re: svn commit: r1733983 - in /jmeter/trunk: bin/ bin/testfiles/ src/protocol/http/org/apache/jmeter/protocol/http/parser/ src/protocol/http/org/apache/jmeter/protocol/http/sampler/ test/src/org/apache/jmeter/protocol/http/parser/ xdocs/

[sebb <se...@gmail.com>]

On 7 March 2016 at 21:22,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Mon Mar  7 21:22:17 2016
> New Revision: 1733983
>
> URL: http://svn.apache.org/viewvc?rev=1733983&view=rev
> Log:
> Bug 59033 - Parallel Download : Rework Parser classes hierarchy to allow pluging parsers for different mime types
> Bugzilla Id: 59033
>
> Added:
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/BaseParser.java   (with props)
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/LinkExtractorParseException.java   (with props)
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/LinkExtractorParser.java   (with props)
> Modified:
>     jmeter/trunk/bin/jmeter.properties
>     jmeter/trunk/bin/testfiles/jmeter-batch.properties
>     jmeter/trunk/bin/testfiles/jmetertest.properties
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParseError.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParseException.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParser.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JTidyHTMLParser.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JsoupBasedHtmlParser.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/LagartoBasedHtmlParser.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/RegexpHTMLParser.java
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>     jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHTMLParser.java
>     jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1733983&r1=1733982&r2=1733983&view=diff
> ==============================================================================
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Mon Mar  7 21:22:17 2016
> @@ -718,7 +718,8 @@ HTTPResponse.parsers=htmlParser wmlParse
>  # Default parser:
>  # This new parser (since 2.10) should perform better than all others
>  # see https://bz.apache.org/bugzilla/show_bug.cgi?id=55632
> -#htmlParser.className=org.apache.jmeter.protocol.http.parser.LagartoBasedHtmlParser
> +# Do not comment this property

Why not? Most other properties have sensible defaults.

It seems wrong to require this to be defined.

> +htmlParser.className=org.apache.jmeter.protocol.http.parser.LagartoBasedHtmlParser

>  # Other parsers:
>  # Default parser before 2.10
> +}
>