[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #283: [FLINK-28228] Never skip generations when observing already upgraded deployment

[GitBox <gi...@apache.org>]

morhidi commented on PR #283:
URL: https://github.com/apache/flink-kubernetes-operator/pull/283#issuecomment-1172045589

   > @morhidi @Aitozi I tried to address the comments. I only added the isFirstDeployment check utility method.
   > 
   > While I partially agreed with some other comments regarding conditions, generation handling for rollbacks etc. but I found no easy way to incoporate those suggestions in a way that would make the code structure or the functionality better.
   > 
   > Even before the comments I have thought about those cases but I think the current logic would work reliably.
   
   Thanks @gyfora appreciate your efforts. Although the generation based deployment validation is a good step towards making sure we have running exactly what we intended to I still have a feeling we need to simplify the logic here. Just thinking out loud: How about generating a hash based on all the spec fields that should trigger an upgrade and we mark the deployment with it. If we find the hash is different we simply do an upgrade?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org