You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/03/23 12:20:04 UTC

Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.


Bugs: ATLAS-2512
    https://issues.apache.org/jira/browse/ATLAS-2512


Repository: atlas


Description
-------

This patch include changes to set propagation one of the following attribute for relationship on lineage page.

* ONE TO TWO
* TWO TO ONE
* BOTH 
* NONE


Diffs
-----

  dashboardv2/public/css/scss/graph.scss 2d7e8a3 
  dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 8fc67e0 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
  dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
  dashboardv2/public/js/views/graph/LineageLayoutView.js f17de83 


Diff: https://reviews.apache.org/r/66244/diff/1/


Testing
-------

Done one round of sanity testing.


Thanks,

pratik pandey


Re: Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

Posted by pratik pandey <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/
-----------------------------------------------------------

(Updated April 10, 2018, 11:31 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.


Changes
-------

show pop modal on edge click


Bugs: ATLAS-2512
    https://issues.apache.org/jira/browse/ATLAS-2512


Repository: atlas


Description
-------

This patch include changes to set propagation one of the following attribute for relationship on lineage page.

* ONE TO TWO
* TWO TO ONE
* BOTH 
* NONE


Diffs (updated)
-----

  dashboardv2/public/css/scss/graph.scss 2d7e8a3 
  dashboardv2/public/css/scss/override.scss e224393 
  dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 8fc67e0 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
  dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html PRE-CREATION 
  dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 25e7120 
  dashboardv2/public/js/views/graph/PropagationPropertyModal.js PRE-CREATION 


Diff: https://reviews.apache.org/r/66244/diff/3/

Changes: https://reviews.apache.org/r/66244/diff/2-3/


Testing
-------

Done one round of sanity testing.


Thanks,

pratik pandey


Re: Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/#review200646
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On April 6, 2018, 10:05 a.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66244/
> -----------------------------------------------------------
> 
> (Updated April 6, 2018, 10:05 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2512
>     https://issues.apache.org/jira/browse/ATLAS-2512
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch include changes to set propagation one of the following attribute for relationship on lineage page.
> 
> * ONE TO TWO
> * TWO TO ONE
> * BOTH 
> * NONE
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/graph.scss 2d7e8a3 
>   dashboardv2/public/css/scss/override.scss e224393 
>   dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
>   dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 8fc67e0 
>   dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
>   dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js f17de83 
> 
> 
> Diff: https://reviews.apache.org/r/66244/diff/2/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>


Re: Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

Posted by pratik pandey <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/
-----------------------------------------------------------

(Updated April 6, 2018, 10:05 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.


Changes
-------

lineage chnages i.e. radio button label change according to entity name


Bugs: ATLAS-2512
    https://issues.apache.org/jira/browse/ATLAS-2512


Repository: atlas


Description
-------

This patch include changes to set propagation one of the following attribute for relationship on lineage page.

* ONE TO TWO
* TWO TO ONE
* BOTH 
* NONE


Diffs (updated)
-----

  dashboardv2/public/css/scss/graph.scss 2d7e8a3 
  dashboardv2/public/css/scss/override.scss e224393 
  dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 8fc67e0 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
  dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
  dashboardv2/public/js/views/graph/LineageLayoutView.js f17de83 


Diff: https://reviews.apache.org/r/66244/diff/2/

Changes: https://reviews.apache.org/r/66244/diff/1-2/


Testing
-------

Done one round of sanity testing.


Thanks,

pratik pandey