You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/05/03 21:49:48 UTC
[GitHub] [superset] justinpark commented on pull request #23908: fix(sqllab): clean comments within quotes
justinpark commented on PR #23908:
URL: https://github.com/apache/superset/pull/23908#issuecomment-1533799081
> Maybe we can change it to remove comments before rendering, but how would you know the comments are safe to remove without rendering the template? Also, if we are removing comments using a SQL parser, the parser is likely to fail before you render the template. Not sure what's the best way forward, but since we are already removing comments in the frontend, it's probably still worth merging this PR first.
I agree with [ktmud](https://github.com/ktmud)'s idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org