You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/01/05 09:27:00 UTC

Review Request 41879: Removed constructor which uses restricted width.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/
-----------------------------------------------------------

Review request for mesos, Michael Park and Jan Schlicht.


Bugs: MESOS-4275
    https://issues.apache.org/jira/browse/MESOS-4275


Repository: mesos


Description
-------

This constructor is not needed as we already provide a constructor which
can construct from a (value, unit) pair. Makes Duration constructors
more uniform.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 

Diff: https://reviews.apache.org/r/41879/diff/


Testing
-------

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier

Re: Review Request 41879: Removed constructor which uses restricted width.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review112842
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41878, 41879]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 8:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41879/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Jan Schlicht.
> 
> 
> Bugs: MESOS-4275
>     https://issues.apache.org/jira/browse/MESOS-4275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This constructor is not needed as we already provide a constructor which
> can construct from a (value, unit) pair. Makes Duration constructors
> more uniform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41879/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41879: Removed constructor which uses restricted width.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review112852
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Jan. 5, 2016, 8:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41879/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Jan Schlicht.
> 
> 
> Bugs: MESOS-4275
>     https://issues.apache.org/jira/browse/MESOS-4275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This constructor is not needed as we already provide a constructor which
> can construct from a (value, unit) pair. Makes Duration constructors
> more uniform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41879/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41879: Removed constructor which uses restricted width.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review113414
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Park


On Jan. 5, 2016, 8:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41879/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Jan Schlicht.
> 
> 
> Bugs: MESOS-4275
>     https://issues.apache.org/jira/browse/MESOS-4275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This constructor is not needed as we already provide a constructor which
> can construct from a (value, unit) pair. Makes Duration constructors
> more uniform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41879/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41879: Removed constructor which uses restricted width.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review113977
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41878, 41879]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 12, 2016, 6:57 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41879/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 6:57 a.m.)
> 
> 
> Review request for mesos, Michael Park and Jan Schlicht.
> 
> 
> Bugs: MESOS-4275
>     https://issues.apache.org/jira/browse/MESOS-4275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This constructor is not needed as we already provide a constructor which
> can construct from a (value, unit) pair. This makes Duration
> constructors more uniform.
> 
> Review: https://reviews.apache.org/r/41879
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 40b22604ec4eb01f44a36624bababb9b59d16bdb 
> 
> Diff: https://reviews.apache.org/r/41879/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41879: Removed constructor which uses restricted width.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 7:57 a.m.)


Review request for mesos, Michael Park and Jan Schlicht.


Changes
-------

Rebased.


Bugs: MESOS-4275
    https://issues.apache.org/jira/browse/MESOS-4275


Repository: mesos


Description (updated)
-------

This constructor is not needed as we already provide a constructor which
can construct from a (value, unit) pair. This makes Duration
constructors more uniform.

Review: https://reviews.apache.org/r/41879


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 40b22604ec4eb01f44a36624bababb9b59d16bdb 

Diff: https://reviews.apache.org/r/41879/diff/


Testing
-------

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier

Re: Review Request 41879: Removed constructor which uses restricted width.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review112855
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Schlicht


On Jan. 5, 2016, 9:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41879/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 9:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Jan Schlicht.
> 
> 
> Bugs: MESOS-4275
>     https://issues.apache.org/jira/browse/MESOS-4275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This constructor is not needed as we already provide a constructor which
> can construct from a (value, unit) pair. Makes Duration constructors
> more uniform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41879/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>