You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/18 18:55:19 UTC
[GitHub] [airflow] ashb opened a new pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
ashb opened a new pull request #20933:
URL: https://github.com/apache/airflow/pull/20933
The position of `@overload` matters -- at least to MyPy, and all
function overloads have to be next to each other.
I also removed the overload for `@task.docker`, as that one _requires_
at least an image to be passed, so isn't valid with no parameters
Closes #20929
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20933:
URL: https://github.com/apache/airflow/pull/20933#issuecomment-1015771649
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #20933:
URL: https://github.com/apache/airflow/pull/20933#discussion_r787101820
##########
File path: docs/apache-airflow/howto/create-custom-decorator.rst
##########
@@ -105,7 +105,7 @@ automatically provided by default. All other arguments should be copied directly
and we recommend adding a comment to explain what arguments are filled automatically by FooDecoratedOperator
and thus not included.
-You should also add an overload at the end of the class similar to this so mypy can recognize the function as
+You should also add an overload that takes a single calable immediately after the "real" definition so mypy can recognize the function as
Review comment:
```suggestion
You should also add an overload that takes a single callable immediately after the "real" definition so mypy can recognize the function as
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20933:
URL: https://github.com/apache/airflow/pull/20933#issuecomment-1015827403
Kube failure is an random EOF in the test harness, not a real problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20933:
URL: https://github.com/apache/airflow/pull/20933#issuecomment-1015735900
Lets double check this does fix the mypy -- it did on my testing on one direct file, but sadly I don't trust it to behave the same when run with all files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20933:
URL: https://github.com/apache/airflow/pull/20933#issuecomment-1015782784
Confirmed mypy changes good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #20933: Correctly specify overloads for TaskFlow API for type-hinting
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #20933:
URL: https://github.com/apache/airflow/pull/20933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org