You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/22 04:00:13 UTC
[GitHub] [hive] aasha commented on a change in pull request #1515: HIVE-24187: Handle _files creation for HA config with same nameservic…
aasha commented on a change in pull request #1515:
URL: https://github.com/apache/hive/pull/1515#discussion_r492461348
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -424,6 +424,20 @@ public String encodeFileUri(String fileUriStr, String fileChecksum, String encod
return encodedUri;
}
+ public static String encodeFileUri(String fileUriStr, String fileChecksum, String cmroot, String encodedSubDir) {
+ String encodedUri = fileUriStr;
+ if ((fileChecksum != null) && (cmroot != null)) {
+ encodedUri = encodedUri + URI_FRAGMENT_SEPARATOR + fileChecksum + URI_FRAGMENT_SEPARATOR + cmroot;
+ } else {
+ encodedUri = encodedUri + URI_FRAGMENT_SEPARATOR + URI_FRAGMENT_SEPARATOR;
Review comment:
why do we have 2 URI_FRAGMENT_SEPARATOR
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -424,6 +424,20 @@ public String encodeFileUri(String fileUriStr, String fileChecksum, String encod
return encodedUri;
}
+ public static String encodeFileUri(String fileUriStr, String fileChecksum, String cmroot, String encodedSubDir) {
+ String encodedUri = fileUriStr;
+ if ((fileChecksum != null) && (cmroot != null)) {
+ encodedUri = encodedUri + URI_FRAGMENT_SEPARATOR + fileChecksum + URI_FRAGMENT_SEPARATOR + cmroot;
+ } else {
+ encodedUri = encodedUri + URI_FRAGMENT_SEPARATOR + URI_FRAGMENT_SEPARATOR;
+ }
+ encodedUri = encodedUri + URI_FRAGMENT_SEPARATOR + ((encodedSubDir != null) ? encodedSubDir : "");
+ if (LOG.isDebugEnabled()) {
Review comment:
Do we need this check?
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -522,6 +522,14 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
REPLCMINTERVAL("hive.repl.cm.interval","3600s",
new TimeValidator(TimeUnit.SECONDS),
"Inteval for cmroot cleanup thread."),
+ REPL_HA_DATAPATH_REPLACE_REMOTE_NAMESERVICE("hive.repl.ha.datapath.replace.remote.nameservice", false,
+ "When HDFS is HA enabled and both source and target clusters are configured with same nameservice names," +
+ "enable this flag and provide a "),
Review comment:
sentence is incomplete
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -424,6 +424,20 @@ public String encodeFileUri(String fileUriStr, String fileChecksum, String encod
return encodedUri;
}
+ public static String encodeFileUri(String fileUriStr, String fileChecksum, String cmroot, String encodedSubDir) {
+ String encodedUri = fileUriStr;
+ if ((fileChecksum != null) && (cmroot != null)) {
Review comment:
empty check not needed?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
##########
@@ -72,6 +76,40 @@ public static void writeOutput(List<List<String>> listValues, Path outputFile, H
writeOutput(listValues, outputFile, hiveConf, false);
}
+ /**
+ * Given a ReplChangeManger's encoded uri, replaces the namespace and returns the modified encoded uri.
+ */
+ public static String replaceNameSpaceInEncodedURI(String cmEncodedURI, HiveConf hiveConf) throws SemanticException {
Review comment:
replace name service?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org