You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Alex Parvulescu <al...@gmail.com> on 2015/08/27 13:51:56 UTC
System.out.println used in unit tests in oak-core
Hi,
I noticed there are quite a few tests using
System.out.println to display various data.
Please replace these calls by proper logging.
Culprits:
- org.apache.jackrabbit.oak.plugins.document.cache.SerializerTest [0]
- org.apache.jackrabbit.oak.plugins.document.ClusterViewTest [1]
- org.apache.jackrabbit.oak.plugins.document.HierarchyConflictTest [2]
- org.apache.jackrabbit.oak.plugins.document.NodeStoreDiffTest [3]
- org.apache.jackrabbit.oak.security.user.MembershipProviderTest [4]
thanks,
alex
[0]
Running org.apache.jackrabbit.oak.plugins.document.cache.SerializerTest
Size 7 null
Size 18 b1
Size 301 b1
Size 9 r14f6ef05471-1-5
Size 9 br14f6ef05472-1-5
[1]
Running org.apache.jackrabbit.oak.plugins.document.ClusterViewTest
{"seq":10,"final":true,"id":"a2b9d562-9536-436f-9b67-5efbb85fbed4","me":21,"active":[21],"deactivating":[],"inactive":[]}
{"seq":10,"final":true,"id":"b8e70adb-4b30-4319-aec8-b28fb1679a4c","me":2,"active":[2],"deactivating":[],"inactive":[3]}
{"seq":10,"final":true,"id":"341ca74f-a2cd-4d81-8a1b-6565f90e22a2","me":2,"active":[2,5,6],"deactivating":[],"inactive":[3]}
{"seq":10,"final":true,"id":"7f0cfb9e-27eb-47fc-934b-89194a18ac0c","me":2,"active":[2],"deactivating":[],"inactive":[3,4,5,6]}
{"seq":10,"final":true,"id":"07ac1a64-dd2c-4d02-add8-e345d808aa7a","me":2,"active":[2,3],"deactivating":[4],"inactive":[5,6]}
{"seq":10,"final":false,"id":"3cd780f0-16ff-4100-a842-c15fcf43e339","me":2,"active":[2,3],"deactivating":[4,5],"inactive":[6]}
[2]
Running org.apache.jackrabbit.oak.plugins.document.HierarchyConflictTest
expected: org.apache.jackrabbit.oak.api.CommitFailedException: OakOak0000:
do not retry merge in this test
expected: org.apache.jackrabbit.oak.api.CommitFailedException: OakOak0000:
do not retry merge in this test
[3]
Running org.apache.jackrabbit.oak.plugins.document.NodeStoreDiffTest
Root at r1-0-1 (r1-0-1)
Root at r2-0-1 (r2-0-1)
Root at r3-0-1 (r3-0-1)
Root at r4-0-1 (r4-0-1)
Root at r1-0-1 (r1-0-1)
Root at r2-0-1 (r2-0-1)
Root at r3-0-1 (r3-0-1)
Root at r4-0-1 (r4-0-1)
[4]
Running org.apache.jackrabbit.oak.security.user.MembershipProviderTest
created 1 groups, 99 users.
created 1 groups, 199 users.
created 1 groups, 299 users.
created 1 groups, 399 users.
created 1 groups, 499 users.
created 1 groups, 599 users.
created 1 groups, 699 users.
created 1 groups, 799 users.
created 1 groups, 899 users.
created 1 groups, 999 users.
created 99 groups, 1 users.
created 199 groups, 1 users.
created 299 groups, 1 users.
created 399 groups, 1 users.
created 499 groups, 1 users.
created 599 groups, 1 users.
created 699 groups, 1 users.
created 799 groups, 1 users.
created 899 groups, 1 users.
created 999 groups, 1 users.
created 11 groups, 89 users.
created 21 groups, 179 users.
created 31 groups, 269 users.
created 41 groups, 359 users.
created 51 groups, 449 users.
created 61 groups, 539 users.
created 71 groups, 629 users.
created 81 groups, 719 users.
created 91 groups, 809 users.
created 100 groups, 900 users.
created 110 groups, 990 users.
created 99 groups, 1 users.
created 1 groups, 99 users.
created 1 groups, 199 users.
created 1 groups, 299 users.
created 1 groups, 399 users.
created 1 groups, 499 users.
created 1 groups, 599 users.
created 1 groups, 699 users.
created 1 groups, 799 users.
created 1 groups, 899 users.
created 1 groups, 999 users.
created 1 groups, 99 users.
created 1 groups, 199 users.
created 1 groups, 299 users.
created 1 groups, 399 users.
created 1 groups, 499 users.
created 1 groups, 599 users.
created 1 groups, 699 users.
created 1 groups, 799 users.
created 1 groups, 899 users.
created 1 groups, 999 users.
created 1 groups, 99 users.
created 1 groups, 199 users.
created 1 groups, 299 users.
created 1 groups, 399 users.
created 1 groups, 499 users.
created 1 groups, 599 users.
created 1 groups, 699 users.
created 1 groups, 799 users.
created 1 groups, 899 users.
created 1 groups, 999 users.
Re: System.out.println used in unit tests in oak-core
Posted by Alex Parvulescu <al...@gmail.com>.
ah, good to know. I was wondering why I am seeing this now :)
On Thu, Aug 27, 2015 at 2:34 PM, Stefan Egli <st...@apache.org> wrote:
> which you might have noticed since I disabled redirectTestOutputToFile [0]
> to debug OAK-3292 so we now have system.out during test runs. I intend to
> put that flag back once the OAK-3292 dust has settled..
>
> Cheers,
> Stefan
> --
> [0] - http://svn.apache.org/r1697676
>
>
> On 27/08/15 13:51, "Alex Parvulescu" <al...@gmail.com> wrote:
>
> >Hi,
> >
> >I noticed there are quite a few tests using
> >System.out.println to display various data.
> >Please replace these calls by proper logging.
> >
> >Culprits:
> > - org.apache.jackrabbit.oak.plugins.document.cache.SerializerTest [0]
> > - org.apache.jackrabbit.oak.plugins.document.ClusterViewTest [1]
> > - org.apache.jackrabbit.oak.plugins.document.HierarchyConflictTest [2]
> > - org.apache.jackrabbit.oak.plugins.document.NodeStoreDiffTest [3]
> > - org.apache.jackrabbit.oak.security.user.MembershipProviderTest [4]
> >
> >thanks,
> >alex
> >
> >[0]
> >Running org.apache.jackrabbit.oak.plugins.document.cache.SerializerTest
> >Size 7 null
> >Size 18 b1
> >Size 301 b1
> >Size 9 r14f6ef05471-1-5
> >Size 9 br14f6ef05472-1-5
> >
> >[1]
> >Running org.apache.jackrabbit.oak.plugins.document.ClusterViewTest
> >{"seq":10,"final":true,"id":"a2b9d562-9536-436f-9b67-5efbb85fbed4","me":21
> >,"active":[21],"deactivating":[],"inactive":[]}
> >{"seq":10,"final":true,"id":"b8e70adb-4b30-4319-aec8-b28fb1679a4c","me":2,
> >"active":[2],"deactivating":[],"inactive":[3]}
> >{"seq":10,"final":true,"id":"341ca74f-a2cd-4d81-8a1b-6565f90e22a2","me":2,
> >"active":[2,5,6],"deactivating":[],"inactive":[3]}
> >{"seq":10,"final":true,"id":"7f0cfb9e-27eb-47fc-934b-89194a18ac0c","me":2,
> >"active":[2],"deactivating":[],"inactive":[3,4,5,6]}
> >{"seq":10,"final":true,"id":"07ac1a64-dd2c-4d02-add8-e345d808aa7a","me":2,
> >"active":[2,3],"deactivating":[4],"inactive":[5,6]}
> >{"seq":10,"final":false,"id":"3cd780f0-16ff-4100-a842-c15fcf43e339","me":2
> >,"active":[2,3],"deactivating":[4,5],"inactive":[6]}
> >
> >[2]
> >Running org.apache.jackrabbit.oak.plugins.document.HierarchyConflictTest
> >expected: org.apache.jackrabbit.oak.api.CommitFailedException: OakOak0000:
> >do not retry merge in this test
> >expected: org.apache.jackrabbit.oak.api.CommitFailedException: OakOak0000:
> >do not retry merge in this test
> >
> >[3]
> >Running org.apache.jackrabbit.oak.plugins.document.NodeStoreDiffTest
> >Root at r1-0-1 (r1-0-1)
> >Root at r2-0-1 (r2-0-1)
> >Root at r3-0-1 (r3-0-1)
> >Root at r4-0-1 (r4-0-1)
> >Root at r1-0-1 (r1-0-1)
> >Root at r2-0-1 (r2-0-1)
> >Root at r3-0-1 (r3-0-1)
> >Root at r4-0-1 (r4-0-1)
> >
> >[4]
> >Running org.apache.jackrabbit.oak.security.user.MembershipProviderTest
> >created 1 groups, 99 users.
> >created 1 groups, 199 users.
> >created 1 groups, 299 users.
> >created 1 groups, 399 users.
> >created 1 groups, 499 users.
> >created 1 groups, 599 users.
> >created 1 groups, 699 users.
> >created 1 groups, 799 users.
> >created 1 groups, 899 users.
> >created 1 groups, 999 users.
> >created 99 groups, 1 users.
> >created 199 groups, 1 users.
> >created 299 groups, 1 users.
> >created 399 groups, 1 users.
> >created 499 groups, 1 users.
> >created 599 groups, 1 users.
> >created 699 groups, 1 users.
> >created 799 groups, 1 users.
> >created 899 groups, 1 users.
> >created 999 groups, 1 users.
> >created 11 groups, 89 users.
> >created 21 groups, 179 users.
> >created 31 groups, 269 users.
> >created 41 groups, 359 users.
> >created 51 groups, 449 users.
> >created 61 groups, 539 users.
> >created 71 groups, 629 users.
> >created 81 groups, 719 users.
> >created 91 groups, 809 users.
> >created 100 groups, 900 users.
> >created 110 groups, 990 users.
> >created 99 groups, 1 users.
> >created 1 groups, 99 users.
> >created 1 groups, 199 users.
> >created 1 groups, 299 users.
> >created 1 groups, 399 users.
> >created 1 groups, 499 users.
> >created 1 groups, 599 users.
> >created 1 groups, 699 users.
> >created 1 groups, 799 users.
> >created 1 groups, 899 users.
> >created 1 groups, 999 users.
> >created 1 groups, 99 users.
> >created 1 groups, 199 users.
> >created 1 groups, 299 users.
> >created 1 groups, 399 users.
> >created 1 groups, 499 users.
> >created 1 groups, 599 users.
> >created 1 groups, 699 users.
> >created 1 groups, 799 users.
> >created 1 groups, 899 users.
> >created 1 groups, 999 users.
> >created 1 groups, 99 users.
> >created 1 groups, 199 users.
> >created 1 groups, 299 users.
> >created 1 groups, 399 users.
> >created 1 groups, 499 users.
> >created 1 groups, 599 users.
> >created 1 groups, 699 users.
> >created 1 groups, 799 users.
> >created 1 groups, 899 users.
> >created 1 groups, 999 users.
>
>
>
Re: System.out.println used in unit tests in oak-core
Posted by Stefan Egli <st...@apache.org>.
which you might have noticed since I disabled redirectTestOutputToFile [0]
to debug OAK-3292 so we now have system.out during test runs. I intend to
put that flag back once the OAK-3292 dust has settled..
Cheers,
Stefan
--
[0] - http://svn.apache.org/r1697676
On 27/08/15 13:51, "Alex Parvulescu" <al...@gmail.com> wrote:
>Hi,
>
>I noticed there are quite a few tests using
>System.out.println to display various data.
>Please replace these calls by proper logging.
>
>Culprits:
> - org.apache.jackrabbit.oak.plugins.document.cache.SerializerTest [0]
> - org.apache.jackrabbit.oak.plugins.document.ClusterViewTest [1]
> - org.apache.jackrabbit.oak.plugins.document.HierarchyConflictTest [2]
> - org.apache.jackrabbit.oak.plugins.document.NodeStoreDiffTest [3]
> - org.apache.jackrabbit.oak.security.user.MembershipProviderTest [4]
>
>thanks,
>alex
>
>[0]
>Running org.apache.jackrabbit.oak.plugins.document.cache.SerializerTest
>Size 7 null
>Size 18 b1
>Size 301 b1
>Size 9 r14f6ef05471-1-5
>Size 9 br14f6ef05472-1-5
>
>[1]
>Running org.apache.jackrabbit.oak.plugins.document.ClusterViewTest
>{"seq":10,"final":true,"id":"a2b9d562-9536-436f-9b67-5efbb85fbed4","me":21
>,"active":[21],"deactivating":[],"inactive":[]}
>{"seq":10,"final":true,"id":"b8e70adb-4b30-4319-aec8-b28fb1679a4c","me":2,
>"active":[2],"deactivating":[],"inactive":[3]}
>{"seq":10,"final":true,"id":"341ca74f-a2cd-4d81-8a1b-6565f90e22a2","me":2,
>"active":[2,5,6],"deactivating":[],"inactive":[3]}
>{"seq":10,"final":true,"id":"7f0cfb9e-27eb-47fc-934b-89194a18ac0c","me":2,
>"active":[2],"deactivating":[],"inactive":[3,4,5,6]}
>{"seq":10,"final":true,"id":"07ac1a64-dd2c-4d02-add8-e345d808aa7a","me":2,
>"active":[2,3],"deactivating":[4],"inactive":[5,6]}
>{"seq":10,"final":false,"id":"3cd780f0-16ff-4100-a842-c15fcf43e339","me":2
>,"active":[2,3],"deactivating":[4,5],"inactive":[6]}
>
>[2]
>Running org.apache.jackrabbit.oak.plugins.document.HierarchyConflictTest
>expected: org.apache.jackrabbit.oak.api.CommitFailedException: OakOak0000:
>do not retry merge in this test
>expected: org.apache.jackrabbit.oak.api.CommitFailedException: OakOak0000:
>do not retry merge in this test
>
>[3]
>Running org.apache.jackrabbit.oak.plugins.document.NodeStoreDiffTest
>Root at r1-0-1 (r1-0-1)
>Root at r2-0-1 (r2-0-1)
>Root at r3-0-1 (r3-0-1)
>Root at r4-0-1 (r4-0-1)
>Root at r1-0-1 (r1-0-1)
>Root at r2-0-1 (r2-0-1)
>Root at r3-0-1 (r3-0-1)
>Root at r4-0-1 (r4-0-1)
>
>[4]
>Running org.apache.jackrabbit.oak.security.user.MembershipProviderTest
>created 1 groups, 99 users.
>created 1 groups, 199 users.
>created 1 groups, 299 users.
>created 1 groups, 399 users.
>created 1 groups, 499 users.
>created 1 groups, 599 users.
>created 1 groups, 699 users.
>created 1 groups, 799 users.
>created 1 groups, 899 users.
>created 1 groups, 999 users.
>created 99 groups, 1 users.
>created 199 groups, 1 users.
>created 299 groups, 1 users.
>created 399 groups, 1 users.
>created 499 groups, 1 users.
>created 599 groups, 1 users.
>created 699 groups, 1 users.
>created 799 groups, 1 users.
>created 899 groups, 1 users.
>created 999 groups, 1 users.
>created 11 groups, 89 users.
>created 21 groups, 179 users.
>created 31 groups, 269 users.
>created 41 groups, 359 users.
>created 51 groups, 449 users.
>created 61 groups, 539 users.
>created 71 groups, 629 users.
>created 81 groups, 719 users.
>created 91 groups, 809 users.
>created 100 groups, 900 users.
>created 110 groups, 990 users.
>created 99 groups, 1 users.
>created 1 groups, 99 users.
>created 1 groups, 199 users.
>created 1 groups, 299 users.
>created 1 groups, 399 users.
>created 1 groups, 499 users.
>created 1 groups, 599 users.
>created 1 groups, 699 users.
>created 1 groups, 799 users.
>created 1 groups, 899 users.
>created 1 groups, 999 users.
>created 1 groups, 99 users.
>created 1 groups, 199 users.
>created 1 groups, 299 users.
>created 1 groups, 399 users.
>created 1 groups, 499 users.
>created 1 groups, 599 users.
>created 1 groups, 699 users.
>created 1 groups, 799 users.
>created 1 groups, 899 users.
>created 1 groups, 999 users.
>created 1 groups, 99 users.
>created 1 groups, 199 users.
>created 1 groups, 299 users.
>created 1 groups, 399 users.
>created 1 groups, 499 users.
>created 1 groups, 599 users.
>created 1 groups, 699 users.
>created 1 groups, 799 users.
>created 1 groups, 899 users.
>created 1 groups, 999 users.