[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #657: Add list tables support in Iceberg catalog

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #657: Add list tables support in Iceberg catalog
URL: https://github.com/apache/incubator-iceberg/pull/657#discussion_r347690144
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
 ##########
 @@ -26,12 +26,22 @@
 import org.apache.iceberg.Transaction;
 import org.apache.iceberg.exceptions.AlreadyExistsException;
 import org.apache.iceberg.exceptions.NoSuchTableException;
+import org.apache.iceberg.exceptions.NotFoundException;
 
 /**
  * A Catalog API for table create, drop, and load operations.
  */
 public interface Catalog {
 
+  /**
+   * Return all the identifiers under this namespace.
 
 Review comment:
   All identifiers or all identifiers that are tables? I think we should consider how to handle catalogs that store views and tables in the same namespace.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org