You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2019/07/30 12:14:09 UTC

[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #1929: Data srcset

Lofesa commented on issue #1929: Data srcset
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1929#issuecomment-516392838
 
 
   
   > I'm concerned about amp-img. I feel like we might not want to rewrite URLs of such images, but >only rewrite their content as part of IPRO. The reason is that the rewrites are user-agent-specific, >and that amp HTML will be cached across user-agents.
   What do you mean with "..that amp HTML will be cached across user-agents" ?
   If the page is served from the origin server, the images are served acordly to the browser user agent, if served from cdn.ampproject.org, the images are served w/ the optimizations for their UA.
   Maybe we exclude it from pagespeed if the referal is cdn.ampproject.org.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services