You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2016/12/08 00:57:26 UTC

[1/7] cordova-plugin-statusbar git commit: CB-11832 Incremented plugin version.

Repository: cordova-plugin-statusbar
Updated Branches:
  refs/heads/2.2.x ad5f7d912 -> a50208bda


CB-11832 Incremented plugin version.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/53d0b04e
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/53d0b04e
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/53d0b04e

Branch: refs/heads/2.2.x
Commit: 53d0b04ed69431139de1a1767a6d311d450211c3
Parents: ad5f7d9
Author: Steve Gill <st...@gmail.com>
Authored: Fri Sep 9 16:08:04 2016 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Fri Sep 9 16:08:04 2016 -0700

----------------------------------------------------------------------
 package.json     | 2 +-
 plugin.xml       | 2 +-
 tests/plugin.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/53d0b04e/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 19f2274..6d0921e 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-statusbar",
-  "version": "2.2.0",
+  "version": "2.2.1-dev",
   "description": "Cordova StatusBar Plugin",
   "cordova": {
     "id": "cordova-plugin-statusbar",

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/53d0b04e/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 1bd0973..2047486 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -22,7 +22,7 @@
     xmlns:rim="http://www.blackberry.com/ns/widgets"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-plugin-statusbar"
-    version="2.2.0">
+    version="2.2.1-dev">
     <name>StatusBar</name>
     <description>Cordova StatusBar Plugin</description>
     <license>Apache 2.0</license>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/53d0b04e/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index c5be4e7..0adf6dc 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -22,7 +22,7 @@
     xmlns:rim="http://www.blackberry.com/ns/widgets"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-plugin-statusbar-tests"
-    version="2.2.0">
+    version="2.2.1-dev">
     <name>Cordova StatusBar Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[3/7] cordova-plugin-statusbar git commit: CB-11191: Statusbar plugin causing issues with webview size

Posted by sh...@apache.org.
CB-11191: Statusbar plugin causing issues with webview size

 This closes #65


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/2c036c9c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/2c036c9c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/2c036c9c

Branch: refs/heads/2.2.x
Commit: 2c036c9c91130293ae09b0206e42c881406138c6
Parents: 940a8ee
Author: Julio C�sar <jc...@gmail.com>
Authored: Wed Sep 21 23:58:25 2016 +0200
Committer: Julio C�sar <jc...@gmail.com>
Committed: Sat Oct 29 00:10:20 2016 +0200

----------------------------------------------------------------------
 src/ios/CDVStatusBar.m | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/2c036c9c/src/ios/CDVStatusBar.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVStatusBar.m b/src/ios/CDVStatusBar.m
index 3e86de6..55f7ed6 100644
--- a/src/ios/CDVStatusBar.m
+++ b/src/ios/CDVStatusBar.m
@@ -90,6 +90,11 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
     }
 }
 
+-(void)cordovaViewWillAppear:(NSNotification*)notification
+{
+    [self resizeWebView];
+}
+
 -(void)statusBarDidChangeFrame:(NSNotification*)notification
 {
     //add a small delay for iOS 7 ( 0.1 seconds )
@@ -112,6 +117,8 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
 
     [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(statusBarDidChangeFrame:) name: UIApplicationDidChangeStatusBarFrameNotification object:nil];
 
+    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(cordovaViewWillAppear:) name: @"CDVViewWillAppearNotification" object:nil];
+
     _statusBarOverlaysWebView = YES; // default
 
     [self initializeStatusBarBackgroundView];


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/7] cordova-plugin-statusbar git commit: CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…"

Posted by sh...@apache.org.
CB-11917 - Remove pull request template checklist item: "iCLA has been submitted\u2026"

 This closes #66


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/940a8ee9
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/940a8ee9
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/940a8ee9

Branch: refs/heads/2.2.x
Commit: 940a8ee92045b365b11790aa5e3e55964ef913a2
Parents: 53d0b04
Author: Shazron Abdullah <sh...@gmail.com>
Authored: Wed Sep 28 01:26:09 2016 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Tue Oct 4 21:34:54 2016 -0700

----------------------------------------------------------------------
 .github/PULL_REQUEST_TEMPLATE.md | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/940a8ee9/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 4bd6da9..91582f4 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -17,7 +17,6 @@ Thanks!
 
 
 ### Checklist
-- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
 - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
 - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
 - [ ] Added automated test coverage as appropriate for this change.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[5/7] cordova-plugin-statusbar git commit: CB-10158 (ios) fix StatusBar issue when recovering from fullscreen video

Posted by sh...@apache.org.
CB-10158 (ios) fix StatusBar issue when recovering from fullscreen video

 This closes #70


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/b7dc5ef7
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/b7dc5ef7
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/b7dc5ef7

Branch: refs/heads/2.2.x
Commit: b7dc5ef7cbc474b0f26f3c66b8a6abfbf953efd4
Parents: 086234b
Author: Julio Cesar Sanchez Hernandez <jc...@gmail.com>
Authored: Sun Oct 30 15:37:58 2016 +0100
Committer: Julio C�sar <jc...@gmail.com>
Committed: Sun Oct 30 17:48:37 2016 +0100

----------------------------------------------------------------------
 src/ios/CDVStatusBar.m | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b7dc5ef7/src/ios/CDVStatusBar.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVStatusBar.m b/src/ios/CDVStatusBar.m
index 55f7ed6..f563e49 100644
--- a/src/ios/CDVStatusBar.m
+++ b/src/ios/CDVStatusBar.m
@@ -473,16 +473,16 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
         CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame;
         statusBarFrame = [self invertFrameIfNeeded:statusBarFrame];
         CGRect frame = self.webView.frame;
+        CGFloat height = statusBarFrame.size.height;
 
         if (!self.statusBarOverlaysWebView) {
-            frame.origin.y = statusBarFrame.size.height;
-            frame.size.height -= statusBarFrame.size.height;
+            // CB-10158 If a full screen video is playing the status bar height will be 0, set it to 20
+            frame.origin.y = height > 0 ? height: 20;
         } else {
-            // even if overlay is used, we want to handle in-call/recording/hotspot larger status bar
-            CGFloat height = statusBarFrame.size.height;
+            // Even if overlay is used, we want to handle in-call/recording/hotspot larger status bar
             frame.origin.y = height >= 20 ? height - 20 : 0;
-            frame.size.height -= frame.origin.y;
         }
+        frame.size.height -= frame.origin.y;
         self.webView.frame = frame;
     } else {
         CGRect bounds = [[UIScreen mainScreen] applicationFrame];


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[6/7] cordova-plugin-statusbar git commit: CB-10288 statusbar plugin interaction with iOS multitasking

Posted by sh...@apache.org.
CB-10288 statusbar plugin interaction with iOS multitasking

 This closes #62


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/6bfc749f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/6bfc749f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/6bfc749f

Branch: refs/heads/2.2.x
Commit: 6bfc749f846e44d2784e93fa7629ec3049ab418d
Parents: b7dc5ef
Author: Jonathan Li <jo...@sap.com>
Authored: Sun Aug 28 16:01:54 2016 -0400
Committer: Julio C�sar <jc...@gmail.com>
Committed: Sun Nov 13 23:14:11 2016 +0100

----------------------------------------------------------------------
 src/ios/CDVStatusBar.m | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/6bfc749f/src/ios/CDVStatusBar.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVStatusBar.m b/src/ios/CDVStatusBar.m
index f563e49..37c6dcd 100644
--- a/src/ios/CDVStatusBar.m
+++ b/src/ios/CDVStatusBar.m
@@ -189,7 +189,7 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
     CGRect statusBarFrame = [UIApplication sharedApplication].statusBarFrame;
 
     if ([[UIApplication sharedApplication]statusBarOrientation] == UIInterfaceOrientationPortraitUpsideDown &&
-        statusBarFrame.size.height + statusBarFrame.origin.y == [[UIScreen mainScreen] bounds].size.height) {
+        statusBarFrame.size.height + statusBarFrame.origin.y == [self.viewController.view.window bounds].size.height) {
 
         // When started in upside-down orientation on iOS 7, status bar will be bound to lower edge of the
         // screen (statusBarFrame.origin.y will be somewhere around screen height). In this case we need to
@@ -207,8 +207,8 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
 
 - (CGRect) invertFrameIfNeeded:(CGRect)rect {
     // landscape is where (width > height). On iOS < 8, we need to invert since frames are
-    // always in Portrait context
-    if (UIInterfaceOrientationIsLandscape([[UIApplication sharedApplication] statusBarOrientation]) && (rect.size.width < rect.size.height)) {
+    // always in Portrait context. Do not run this on ios 8 or above to avoid breaking ipad pro multitask layout
+    if (!IsAtLeastiOSVersion(@"8.0") && UIInterfaceOrientationIsLandscape([[UIApplication sharedApplication] statusBarOrientation])) {
         CGFloat temp = rect.size.width;
         rect.size.width = rect.size.height;
         rect.size.height = temp;
@@ -447,7 +447,7 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
     BOOL isIOS7 = (IsAtLeastiOSVersion(@"7.0"));
 
     if (isIOS7) {
-        CGRect bounds = [[UIScreen mainScreen] bounds];
+        CGRect bounds = [self.viewController.view.window bounds];
         bounds = [self invertFrameIfNeeded:bounds];
 
         if (UIInterfaceOrientationIsPortrait([[UIApplication sharedApplication] statusBarOrientation])) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[7/7] cordova-plugin-statusbar git commit: CB-12224 Updated version and RELEASENOTES.md for release 2.2.1

Posted by sh...@apache.org.
CB-12224 Updated version and RELEASENOTES.md for release 2.2.1


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/a50208bd
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/a50208bd
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/a50208bd

Branch: refs/heads/2.2.x
Commit: a50208bda2728902c1e1640a7ebeae599fb42b5d
Parents: 6bfc749
Author: Shazron Abdullah <sh...@apache.org>
Authored: Wed Dec 7 16:39:46 2016 -0800
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Wed Dec 7 16:39:46 2016 -0800

----------------------------------------------------------------------
 RELEASENOTES.md  | 8 ++++++++
 package.json     | 2 +-
 plugin.xml       | 2 +-
 tests/plugin.xml | 2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/a50208bd/RELEASENOTES.md
----------------------------------------------------------------------
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index 0abff40..9568a1b 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -20,6 +20,14 @@
 -->
 # Release Notes
 
+### 2.2.1 (Dec 07, 2016)
+* [CB-10288](https://issues.apache.org/jira/browse/CB-10288) statusbar plugin interaction with iOS multitasking
+* [CB-10158](https://issues.apache.org/jira/browse/CB-10158) (ios) fix StatusBar issue when recovering from fullscreen video
+* [CB-10341](https://issues.apache.org/jira/browse/CB-10341) ios, document statusTap event
+* [CB-11191](https://issues.apache.org/jira/browse/CB-11191) Statusbar plugin causing issues with webview size
+* [CB-11917](https://issues.apache.org/jira/browse/CB-11917) - Remove pull request template checklist item: "iCLA has been submitted\u2026"
+* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) Incremented plugin version.
+
 ### 2.2.0 (Sep 08, 2016)
 * [CB-11795](https://issues.apache.org/jira/browse/CB-11795) Add 'protective' entry to cordovaDependencies
 * Handle extended status bar on **iOS**

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/a50208bd/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 6d0921e..4027d6c 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-statusbar",
-  "version": "2.2.1-dev",
+  "version": "2.2.1",
   "description": "Cordova StatusBar Plugin",
   "cordova": {
     "id": "cordova-plugin-statusbar",

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/a50208bd/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 2047486..a84ab03 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -22,7 +22,7 @@
     xmlns:rim="http://www.blackberry.com/ns/widgets"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-plugin-statusbar"
-    version="2.2.1-dev">
+    version="2.2.1">
     <name>StatusBar</name>
     <description>Cordova StatusBar Plugin</description>
     <license>Apache 2.0</license>

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/a50208bd/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index 0adf6dc..34b1bc1 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -22,7 +22,7 @@
     xmlns:rim="http://www.blackberry.com/ns/widgets"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova-plugin-statusbar-tests"
-    version="2.2.1-dev">
+    version="2.2.1">
     <name>Cordova StatusBar Plugin Tests</name>
     <license>Apache 2.0</license>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[4/7] cordova-plugin-statusbar git commit: CB-10341 ios, document statusTap event

Posted by sh...@apache.org.
CB-10341 ios, document statusTap event

 This closes #69


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/086234b8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/086234b8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/086234b8

Branch: refs/heads/2.2.x
Commit: 086234b881f3b8d75b3609d4ceb70497539938f8
Parents: 2c036c9
Author: Julio Cesar Sanchez Hernandez <jc...@gmail.com>
Authored: Sun Oct 30 11:32:50 2016 +0100
Committer: Julio C�sar <jc...@gmail.com>
Committed: Sun Oct 30 17:46:36 2016 +0100

----------------------------------------------------------------------
 README.md | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/086234b8/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index 8196a86..22c84d2 100644
--- a/README.md
+++ b/README.md
@@ -113,6 +113,11 @@ Properties
 
 - StatusBar.isVisible
 
+Events
+------
+
+- statusTap
+
 Permissions
 -----------
 
@@ -310,3 +315,19 @@ Supported Platforms
 - Windows Phone 7
 - Windows Phone 8
 - Windows Phone 8.1
+
+
+statusTap
+=========
+
+Listen for this event to know if the statusbar was tapped.
+
+    window.addEventListener('statusTap', function() {
+        // scroll-up with document.body.scrollTop = 0; or do whatever you want
+    });
+
+
+Supported Platforms
+-------------------
+
+- iOS


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org