You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/12/15 11:25:58 UTC

[jira] [Commented] (PHOENIX-3536) Remove creating unnecessary phoenix connections in MR Tasks of Hive

    [ https://issues.apache.org/jira/browse/PHOENIX-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751118#comment-15751118 ] 

Hadoop QA commented on PHOENIX-3536:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12843380/PHOENIX-3536.patch
  against master branch at commit 1a6a689b87de9c58e784276d542ed0bdb555962b.
  ATTACHMENT ID: 12843380

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 43 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        this.isRequestLevelMetricsEnabled = JDBCUtil.isCollectingRequestLevelMetricsEnabled(url, this.info, this.services.getProps());
+        PColumn column = new PColumnImpl(PNameFactory.newName("c1"), PNameFactory.newName("f1"), PDecimal.INSTANCE, maxLen, scale,
+                new PColumnImpl(PNameFactory.newName("c2"), PNameFactory.newName("f1"), PDecimal.INSTANCE, maxLen, scale,
+                new PColumnImpl(PNameFactory.newName("c3"), PNameFactory.newName("f1"), PInteger.INSTANCE, maxLen, scale,
+                new PColumnImpl(PNameFactory.newName("c4"), PNameFactory.newName("f1"), PChar.INSTANCE, maxLen, scale,
+        ProjectedColumnExpression colExp = new ProjectedColumnExpression(column, columns, 1, "test");
+                            PhoenixEmbeddedDriver.ConnectionInfo.create(PHOENIX_CONNECTIONLESS_JDBC_URL),
+                             * deeply copying properties by QueryServices causes performance degradation.
+                        public HTableInterface getTable(final byte[] tableName) throws SQLException {
+        ConnectionQueryServices queryServices = qplan.getContext().getConnection().getQueryServices();

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/697//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/697//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/697//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/697//console

This message is automatically generated.

> Remove creating unnecessary phoenix connections in MR Tasks of Hive
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-3536
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3536
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Jeongdae Kim
>            Assignee: Jeongdae Kim
>              Labels: HivePhoenix
>         Attachments: PHOENIX-3536.patch
>
>
> PhoenixStorageHandler creates phoenix connections to make QueryPlan in getSplit phase(prepare MR) and getRecordReader phase(Map) while running MR Job.
> in phoenix, it spends too many times to create the first phoenix connection(QueryServices) for specific URL. (checking and loading phoenix schema information)
> i found it is possible to remove creating query plan again in Map phase(getRecordReader()) by serializing QueryPlan created from Input format ans passing this plan to record reader. 
>  this approach improves scan performance by removing trying to unnecessary connection in map phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)