You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Srikanth Sundarrajan <sr...@hotmail.com> on 2013/07/31 03:43:00 UTC
Review Request 13095: FALCON-62 Falcon compilation with hadoop 2.0 libs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13095/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-62
https://issues.apache.org/jira/browse/FALCON-62
Repository: falcon-git
Description
-------
Falcon compilation with hadoop 2.0 libs
Diffs
-----
common/pom.xml 00d1f28
hadoop-webapp/pom.xml 6c1e2ac
messaging/pom.xml 820734d
oozie-el-extensions/pom.xml 8bd7da2
oozie/pom.xml a0499e3
pom.xml a7c745e
process/pom.xml b024a70
replication/pom.xml 83a4cca
test-util/pom.xml 9ebc056
webapp/pom.xml 86242c2
Diff: https://reviews.apache.org/r/13095/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 13095: FALCON-62 Falcon compilation with hadoop 2.0 libs
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13095/#review24325
-----------------------------------------------------------
Will update the new patch soon
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48164>
done
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48165>
done
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48166>
will check
messaging/pom.xml
<https://reviews.apache.org/r/13095/#comment48168>
done
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48169>
was trying to fix type and added another:) done
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48171>
done
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48173>
done
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48174>
done
pom.xml
<https://reviews.apache.org/r/13095/#comment48161>
v2 patch is after rebase. Which one did you upload?
pom.xml
<https://reviews.apache.org/r/13095/#comment48163>
done
replication/pom.xml
<https://reviews.apache.org/r/13095/#comment48176>
there are no deps required for hadoop profile 1
test-util/pom.xml
<https://reviews.apache.org/r/13095/#comment48177>
super pom can just define dependency management, but individual module poms need to define actual dependencies. So, profile is required in module poms. Profiles are not inherited from super pom to module poms
- shwethags
On July 31, 2013, 1:42 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13095/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 1:42 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-62
> https://issues.apache.org/jira/browse/FALCON-62
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon compilation with hadoop 2.0 libs
>
>
> Diffs
> -----
>
> common/pom.xml 00d1f28
> hadoop-webapp/pom.xml 6c1e2ac
> messaging/pom.xml 820734d
> oozie-el-extensions/pom.xml 8bd7da2
> oozie/pom.xml a0499e3
> pom.xml a7c745e
> process/pom.xml b024a70
> replication/pom.xml 83a4cca
> test-util/pom.xml 9ebc056
> webapp/pom.xml 86242c2
>
> Diff: https://reviews.apache.org/r/13095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 13095: FALCON-62 Falcon compilation with hadoop 2.0 libs
Posted by sh...@inmobi.com.
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > common/pom.xml, line 50
> > <https://reviews.apache.org/r/13095/diff/1/?file=331075#file331075line50>
> >
> > Why is this not in test scope ?
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > common/pom.xml, line 70
> > <https://reviews.apache.org/r/13095/diff/1/?file=331075#file331075line70>
> >
> > This ought to be in test scope
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > common/pom.xml, line 110
> > <https://reviews.apache.org/r/13095/diff/1/?file=331075#file331075line110>
> >
> > Why does commons module need to depend on jsp-api. This can create issues when app is deployed in other containers such as tomcat which bundles specific jsp-api compatible with that stack
Its required for EL evaluation
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > messaging/pom.xml, line 50
> > <https://reviews.apache.org/r/13095/diff/1/?file=331077#file331077line50>
> >
> > test scope?
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > oozie/pom.xml, line 129
> > <https://reviews.apache.org/r/13095/diff/1/?file=331079#file331079line129>
> >
> > typo: shouldn't this be excludeBinding?
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > oozie/pom.xml, line 146
> > <https://reviews.apache.org/r/13095/diff/1/?file=331079#file331079line146>
> >
> > excludeBinding?
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > oozie/pom.xml, line 163
> > <https://reviews.apache.org/r/13095/diff/1/?file=331079#file331079line163>
> >
> > excludeBinding?
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > pom.xml, line 539
> > <https://reviews.apache.org/r/13095/diff/1/?file=331080#file331080line539>
> >
> > Needs to be rebased after FALCON-65. FALCON-65 includes changes here to exclude jasper dependencies.
v2 patch was rebased. Which one did you upload?
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > pom.xml, line 858
> > <https://reviews.apache.org/r/13095/diff/1/?file=331080#file331080line858>
> >
> > Avoidable white space change
done
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > replication/pom.xml, line 35
> > <https://reviews.apache.org/r/13095/diff/1/?file=331082#file331082line35>
> >
> > Why doesn't this module require profile-1 ?
> >
No deps required for profile 1
> On July 31, 2013, 2:01 a.m., Srikanth Sundarrajan wrote:
> > test-util/pom.xml, line 90
> > <https://reviews.apache.org/r/13095/diff/1/?file=331083#file331083line90>
> >
> > Are the dependencies additive ? There are two sections of these, 1. under profile and one is default. If this is possible, why not put the profile definition in super pom and have all the module poms inherit it ?
super pom can define dependency management, but module poms need to define actual dependencies. Also, profiles are not inherited from super pom
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13095/#review24311
-----------------------------------------------------------
On July 31, 2013, 1:42 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13095/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 1:42 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-62
> https://issues.apache.org/jira/browse/FALCON-62
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon compilation with hadoop 2.0 libs
>
>
> Diffs
> -----
>
> common/pom.xml 00d1f28
> hadoop-webapp/pom.xml 6c1e2ac
> messaging/pom.xml 820734d
> oozie-el-extensions/pom.xml 8bd7da2
> oozie/pom.xml a0499e3
> pom.xml a7c745e
> process/pom.xml b024a70
> replication/pom.xml 83a4cca
> test-util/pom.xml 9ebc056
> webapp/pom.xml 86242c2
>
> Diff: https://reviews.apache.org/r/13095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 13095: FALCON-62 Falcon compilation with hadoop 2.0 libs
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13095/#review24311
-----------------------------------------------------------
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48137>
Why is this not in test scope ?
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48138>
This ought to be in test scope
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48139>
Why does commons module need to depend on jsp-api. This can create issues when app is deployed in other containers such as tomcat which bundles specific jsp-api compatible with that stack
messaging/pom.xml
<https://reviews.apache.org/r/13095/#comment48140>
test scope?
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48141>
typo: shouldn't this be excludeBinding?
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48142>
excludeBinding?
oozie/pom.xml
<https://reviews.apache.org/r/13095/#comment48143>
excludeBinding?
pom.xml
<https://reviews.apache.org/r/13095/#comment48135>
Needs to be rebased after FALCON-65. FALCON-65 includes changes here to exclude jasper dependencies.
pom.xml
<https://reviews.apache.org/r/13095/#comment48136>
Avoidable white space change
replication/pom.xml
<https://reviews.apache.org/r/13095/#comment48144>
Why doesn't this module require profile-1 ?
test-util/pom.xml
<https://reviews.apache.org/r/13095/#comment48145>
Are the dependencies additive ? There are two sections of these, 1. under profile and one is default. If this is possible, why not put the profile definition in super pom and have all the module poms inherit it ?
- Srikanth Sundarrajan
On July 31, 2013, 1:42 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13095/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 1:42 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-62
> https://issues.apache.org/jira/browse/FALCON-62
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon compilation with hadoop 2.0 libs
>
>
> Diffs
> -----
>
> common/pom.xml 00d1f28
> hadoop-webapp/pom.xml 6c1e2ac
> messaging/pom.xml 820734d
> oozie-el-extensions/pom.xml 8bd7da2
> oozie/pom.xml a0499e3
> pom.xml a7c745e
> process/pom.xml b024a70
> replication/pom.xml 83a4cca
> test-util/pom.xml 9ebc056
> webapp/pom.xml 86242c2
>
> Diff: https://reviews.apache.org/r/13095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 13095: FALCON-62 Falcon compilation with hadoop 2.0 libs
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13095/#review24326
-----------------------------------------------------------
common/pom.xml
<https://reviews.apache.org/r/13095/#comment48179>
Its used for EL expression evaluation
- shwethags
On July 31, 2013, 1:42 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13095/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 1:42 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-62
> https://issues.apache.org/jira/browse/FALCON-62
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon compilation with hadoop 2.0 libs
>
>
> Diffs
> -----
>
> common/pom.xml 00d1f28
> hadoop-webapp/pom.xml 6c1e2ac
> messaging/pom.xml 820734d
> oozie-el-extensions/pom.xml 8bd7da2
> oozie/pom.xml a0499e3
> pom.xml a7c745e
> process/pom.xml b024a70
> replication/pom.xml 83a4cca
> test-util/pom.xml 9ebc056
> webapp/pom.xml 86242c2
>
> Diff: https://reviews.apache.org/r/13095/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>