You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/14 18:57:44 UTC
[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #19671: [submodule] Upgrade oneDNN to v2.0
bartekkuncer opened a new pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671
This change will upgrade oneDNN on branch 1.8.x to v2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-747260486
> @bartekkuncer what is in the oneDNN 2.0 upgrade that warrants backporting to the 1.8.x branch? Is it just bug fixes or significant feature enhancements?
>
> Whats the motivation for needing this in 1.8.x and not just moving forward to v1.x (and possibly a 1.9.0 release) with this new functionality?
@samskalicky Well there is no actual need to upgrade oneDNN on branch 1.8.x. Just wanted to have the most recent version there, but if you believe it is unnecessary or even problematic, we can just upgrade it on branch 1.x and have it in future releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-746752094
@bartekkuncer what is in the oneDNN 2.0 upgrade that warrants backporting to the 1.8.x branch? Is it just bug fixes or significant feature enhancements?
Whats the motivation for needing this in 1.8.x and not just moving forward to v1.x (and possibly a 1.9.0 release) with this new functionality?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky edited a comment on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
samskalicky edited a comment on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-747271255
> @samskalicky Well there is no actual need to upgrade oneDNN on branch 1.8.x. Just wanted to have the most recent version there, but if you believe it is unnecessary or even problematic, we can just upgrade it on branch 1.x and have it in future releases.
Thanks! I would prefer to stop backporting PRs to 1.8.x that arent necessary (ie. dont fix a bug, or are general things) and continue focusing on the future. Obviously if theres a real need we should do it. If you think the 2.0 release of oneDNN is a big step we should start planning a 1.9 release of MXNet that includes that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-746324752
I'm ok with merging. cc @samskalicky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-745208087
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-745208034
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky edited a comment on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
samskalicky edited a comment on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-747271255
> @samskalicky Well there is no actual need to upgrade oneDNN on branch 1.8.x. Just wanted to have the most recent version there, but if you believe it is unnecessary or even problematic, we can just upgrade it on branch 1.x and have it in future releases.
Thanks! I would prefer to stop backporting PRs to 1.8.x that arent necessary (ie. dont fix a bug, or are general things) and continue focusing on the future. Obviously if theres a real need we should do it. If you think the 2.0 release of oneDNN is a big step we should start planning a 1.9 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-745817348
@szha Please help with the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19671: [submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-744641707
Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, miscellaneous, windows-cpu, website, centos-gpu, sanity, clang, edge, unix-cpu, windows-gpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-745278883
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-745278936
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer closed pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer closed pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #19671: [1.8.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19671:
URL: https://github.com/apache/incubator-mxnet/pull/19671#issuecomment-747271255
> @samskalicky Well there is no actual need to upgrade oneDNN on branch 1.8.x. Just wanted to have the most recent version there, but if you believe it is unnecessary or even problematic, we can just upgrade it on branch 1.x and have it in future releases.
Thanks! I would prefer to stop backporting PRs to 1.8.x that arent necessary (ie. dont fix a bug, or are needed for a specific use-case) and continue focusing on the future. If you think the 2.0 release is a big step we should start planning a 1.9 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org