You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/01/02 07:38:08 UTC
[Impala-ASF-CR] IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14965
Change subject: IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
......................................................................
IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
FE test PlannerTest.testHdfs depends on the result of year(now()) to be
2019, which is wrong after we enter 2020. Replace it with another
expression not depending on now().
Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
---
M testdata/workloads/functional-planner/queries/PlannerTest/hdfs.test
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/14965/1
--
To view, visit http://gerrit.cloudera.org:8080/14965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Gerrit-Change-Number: 14965
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14965 )
Change subject: IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5374/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Gerrit-Change-Number: 14965
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 11:19:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14965 )
Change subject: IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5356/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Gerrit-Change-Number: 14965
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 08:07:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14965 )
Change subject: IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Gerrit-Change-Number: 14965
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 15:49:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14965 )
Change subject: IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Gerrit-Change-Number: 14965
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 10:23:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14965 )
Change subject: IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
......................................................................
IMPALA-9272: Fix PlannerTest.testHdfs depending on year(now())
FE test PlannerTest.testHdfs depends on the result of year(now()) to be
2019, which is wrong after we enter 2020. Replace it with another
expression not depending on now().
Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Reviewed-on: http://gerrit.cloudera.org:8080/14965
Reviewed-by: Gabor Kaszab <ga...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-planner/queries/PlannerTest/hdfs.test
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Gabor Kaszab: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b3df560d69e40d3f2332ff242362bd36bbf6b64
Gerrit-Change-Number: 14965
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>