You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/26 01:15:19 UTC

[GitHub] [tvm] Lunderberg edited a comment on pull request #8127: [Vulkan] Add device capabilities to Target, use in codegen

Lunderberg edited a comment on pull request #8127:
URL: https://github.com/apache/tvm/pull/8127#issuecomment-848383793


   Definitely agreed, `vulkan.cc` could do with a bit of splitting for readability at this point.  I was also thinking that the `VulkanContext` would be good to split out into a separate file, and could have the device-specific initialization logic moved to it.  This PR pushes the `VulkanDeviceAPI` constructor to nearly 300 lines, which is a bit difficult for me to follow.
   
   Edit: Though I think it would be best for me to do so in a separate PR, in order to separate out functionality changes from refactoring.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org