You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 05:11:19 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #30366: [SPARK-33440][CORE] Separate the calculation for the next renewal date for each delegation token

HeartSaVioR commented on pull request #30366:
URL: https://github.com/apache/spark/pull/30366#issuecomment-726518585


   I sought into the test code to add the test, but I haven't found any on calculation. 
   
   I'll need to mock HadoopFSDelegationTokenProvider in any way (mocking, subclassing) which also requires changing some methods from `private` to at least `private[deploy]`. I'll need to also deal with Credentials and create some Tokens & AbstractDelegationTokenIdentifiers for test purpose. Given the actual change is 50 lines, the requirements of the testing sounds like a bit huge, but I'll try out if we think it's still necessary to construct the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org