You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/04/11 09:13:53 UTC

[GitHub] [incubator-opendal] Xuanwo opened a new issue, #1907: Tracking issues of async reqsign migration

Xuanwo opened a new issue, #1907:
URL: https://github.com/apache/incubator-opendal/issues/1907

   This issue is used to track our async reqsign migration. See https://github.com/apache/incubator-opendal/pull/1902 for example.
   
   We should:
   
   - Add `XxxCore` which contains signer and other config values
   - All other struct like `Backend`, `Pager`, `Writer` should hold `Arc<XxxCore>`
   - All function should be refactored.
   
   ## Tasks
   
   - [ ] https://github.com/apache/incubator-opendal/pull/1902
   - [ ] https://github.com/apache/incubator-opendal/pull/1903
   - [ ] https://github.com/apache/incubator-opendal/pull/1906
   - [ ] obs
   - [ ] oss
   - [ ] s3 @Xuanwo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] suyanhanx commented on issue #1907: Tracking issues of async reqsign migration

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #1907:
URL: https://github.com/apache/incubator-opendal/issues/1907#issuecomment-1502979006

   Would you introduce why we need to migrate? As I didnot find any reason at reqsign repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo closed issue #1907: Tracking issues of async reqsign migration

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #1907: Tracking issues of async reqsign migration
URL: https://github.com/apache/incubator-opendal/issues/1907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on issue #1907: Tracking issues of async reqsign migration

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1907:
URL: https://github.com/apache/incubator-opendal/issues/1907#issuecomment-1502967573

   cc @suyanhanx, do you want to take obs or oss?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on issue #1907: Tracking issues of async reqsign migration

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1907:
URL: https://github.com/apache/incubator-opendal/issues/1907#issuecomment-1504527122

   Thanks @suyanhanx for your help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-opendal] Xuanwo commented on issue #1907: Tracking issues of async reqsign migration

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1907:
URL: https://github.com/apache/incubator-opendal/issues/1907#issuecomment-1503023978

   reqsign used to use ureq to do blocking request for auth. But we find it could block the entire tokio runtime if there are many concurrent blocking request. So we change the auth API to async which powered by request.
   
   Along with this change, reqsign did some refactor to polish the public API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org