You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2020/08/18 06:38:47 UTC
[DISCUSS] Draft Tags & After Release Cleanup
This discussion is to update our release process, potentially improve community understanding, and as well cleaning up after a successful or failed release.
I want the following rules to be implemented and will start the vote after keeping this discussion open within 24 hours for any modifications, suggestions, feedback, or additions.
1. Prefix our draft tags with `draft/`
Currently, all of our draft tags, used for release, do not contain any prefix and shows only a version number.
It appears this creates confusion within the community. Too many people always ask, "Why is the version not released in npm". I have always noticed these questions only when the draft tag exists.
I am hoping that this addition to the release process will help reduce some of the confusion.
2. After a successful or failed vote, remove the `draft/` tag
IMO, keeping the draft tag is not necessary. It is supposed to be a temporary tag used only during the voting process.
To reduce the clutter in our GH repos, it would be nice to remove these draft tags.
If anyone is relying upon a draft tag in a production environment, the usage was their own risk.
Also, with the addition of the two rules above, I will append to the vote as well the cleanup request to remove all current existing draft tags from all of our repos. Only tags that have a `rel` tag will be removed.
For example, if there is a tag `1.0.0` and `rel/1.0.0`, then tag `1.0.0` will be removed.
If there is a tag that doesn’t have a `rel` tag, it will not be deleted and a future email will be created to discuss these unknown tags to figure out what action to be performed.
We had this discussion before but never started a vote thread. I will be creating that thread shortly.
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Bryan Ellis <er...@apache.org>.
> At this point I think almost all clean tags should match accepted rel
> (release) tags.
>
> Any clean tags that are for rejected drafts should definitely be deleted.
>
> Just as a small, personal preference, I would not favor deleting any
> clean tags that already match accepted rel (release) tags.
+1
Understood.
For this vote, existing clean tags will not be removed as part of a cleanup process.
If I come across any tags that does not have a `rel/` tag, I will make a note and potentially open a separate vote for those specifically.
> On Aug 19, 2020, at 10:48, Chris Brody <ch...@gmail.com> wrote:
>
>> `draft/` tag prefix is for drafts
>
> +1
>
>> `rel/` tag prefix is for releases
>
> +1
>
>> No more clean tags will be created
>
> OK as discussed below
>
>> `rel/` tags has and will always be the accepted release tag, unless changed in the future.
>
> +1
>
>> We never used clean tags as an official release. We have always told users that clean tags “are not official” and to “please wait for the rel/ tags and or NPM package” as those were considered our final and approved releases.
>
> yup
>
>> If we want to switch from using the “rel/“ prefix to a clean tag (no prefix) for final releases, that should be a separate discussion and vote.
>
> +1
>
>> Side note about the clean tags:
>> On one of my last releases, I created a draft clean tag to submit in a release vote email and within 10 minutes someone posted on Twitter that we have already released just based on the tag.
>> This is why IMO clean tags should not be draft and probably not left around.
>
> At this point I think almost all clean tags should match accepted rel
> (release) tags.
>
> Any clean tags that are for rejected drafts should definitely be deleted.
>
> Just as a small, personal preference, I would not favor deleting any
> clean tags that already match accepted rel (release) tags.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Chris Brody <ch...@gmail.com>.
> `draft/` tag prefix is for drafts
+1
> `rel/` tag prefix is for releases
+1
> No more clean tags will be created
OK as discussed below
> `rel/` tags has and will always be the accepted release tag, unless changed in the future.
+1
> We never used clean tags as an official release. We have always told users that clean tags “are not official” and to “please wait for the rel/ tags and or NPM package” as those were considered our final and approved releases.
yup
> If we want to switch from using the “rel/“ prefix to a clean tag (no prefix) for final releases, that should be a separate discussion and vote.
+1
> Side note about the clean tags:
> On one of my last releases, I created a draft clean tag to submit in a release vote email and within 10 minutes someone posted on Twitter that we have already released just based on the tag.
> This is why IMO clean tags should not be draft and probably not left around.
At this point I think almost all clean tags should match accepted rel
(release) tags.
Any clean tags that are for rejected drafts should definitely be deleted.
Just as a small, personal preference, I would not favor deleting any
clean tags that already match accepted rel (release) tags.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Bryan Ellis <er...@apache.org>.
Hopefully this helps clear up some questions
The Outcome of the Vote
`draft/` tag prefix is for drafts
`rel/` tag prefix is for releases
No more clean tags will be created
[OPTIONAL] Existing clean tags should be removed as they were the OLD draft tags
Responses
>> I would favor keeping both `x.x.x` and `rel/x.x.x` tags for the
>> existing releases that were not rejected.
The last item for removing the existing clean tags could be omitted from the request. I was only adding this as an additional proposal to perform the cleanup process that we lacked in the past.
>> Am I right that with this proposal, we would not need to make
>> `rel/x.x.x` tags for accepted releases after this proposal is
>> accepted?
No, we still be making `rel/` tags.
`rel/` tags has and will always be the accepted release tag, unless changed in the future.
We will no longer be making clean tags.
Additional Information
We never used clean tags as an official release. We have always told users that clean tags “are not official” and to “please wait for the rel/ tags and or NPM package” as those were considered our final and approved releases.
If we want to switch from using the “rel/“ prefix to a clean tag (no prefix) for final releases, that should be a separate discussion and vote.
The goal of this discussion/vote is focused only on:
The draft tag prefixing (To remove confusion)
The process of cleaning up of draft tags after release process (To keep our repo clean of clutter)
Potentially the cleanup of existing drafts (To try and cleanup existing clutter)
Side note about the clean tags:
On one of my last releases, I created a draft clean tag to submit in a release vote email and within 10 minutes someone posted on Twitter that we have already released just based on the tag.
This is why IMO clean tags should not be draft and probably not left around.
> On Aug 19, 2020, at 8:30, Norman Breau <no...@normanbreau.com> wrote:
>
> +1 on cleaning old draft tags
> +1 on removing draft tags upon vote resolution (regardless of success or failure)
>
> I don't have a strong preference for tag names, draft is fine to me, especially as the default... If we run into a specific case during a release discussion/vote where another tag name is preferable... we can be flexible enough to discuss that in a release discussion thread for that particular release.
> Norman Breau
> Software Developer
>
> norman@normanbreau.com (https://link.getmailspring.com/link/5668E2C6-02CF-4E96-96FA-160F5C615C6F@getmailspring.com/0?redirect=mailto%3Anorman%40normanbreau.com&recipient=ZGV2QGNvcmRvdmEuYXBhY2hlLm9yZw%3D%3D)
> https://breautek.com (https://link.getmailspring.com/link/5668E2C6-02CF-4E96-96FA-160F5C615C6F@getmailspring.com/2?redirect=https%3A%2F%2Fbreautek.com&recipient=ZGV2QGNvcmRvdmEuYXBhY2hlLm9yZw%3D%3D)
>
> On Aug 18 2020, at 9:40 am, Chris Brody <ch...@gmail.com> wrote:
>>>> The name "draft" for tags in the release process is not that clear to me. I suggest "rc" for release candidate. And yes we should clean these tags up.
>>
>> -1 on "rc" on my part. I have seen other projects use "rc" to mean an
>> rc version that comes before a stable version.
>>
>>> During the vote, people can append which tag name they prefer.
>> +1
>>> Anyways, I don't want this decision and vote to end like last time because of a tag name.
>> +1 (+100)
>>>> I am not sure about removing all tags without the rel prefix and not creating these anymore. These are easy to remember and type tags to get a specific version. Personally I would keep them and create them with the new process after a vote too. "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
>>>
>>> I am trying to clean up the repos as well. Keep draft tags are not idea IMO. Some repos have 141 tags and half of those are most likely the draft tags which has a corresponding rel tag with identical commit ids.
>>
>> I would favor keeping both `x.x.x` and `rel/x.x.x` tags for the
>> existing releases that were not rejected.
>>
>>>> "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
>> +1.
>> Am I right that with this proposal, we would not need to make
>> `rel/x.x.x` tags for accepted releases after this proposal is
>> accepted?
>>
>>> I am not looking to remove the `rel/` tag process. That must remain and those tags will remain.
>> +1
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Norman Breau <no...@normanbreau.com>.
+1 on cleaning old draft tags
+1 on removing draft tags upon vote resolution (regardless of success or failure)
I don't have a strong preference for tag names, draft is fine to me, especially as the default... If we run into a specific case during a release discussion/vote where another tag name is preferable... we can be flexible enough to discuss that in a release discussion thread for that particular release.
Norman Breau
Software Developer
norman@normanbreau.com (https://link.getmailspring.com/link/5668E2C6-02CF-4E96-96FA-160F5C615C6F@getmailspring.com/0?redirect=mailto%3Anorman%40normanbreau.com&recipient=ZGV2QGNvcmRvdmEuYXBhY2hlLm9yZw%3D%3D)
https://breautek.com (https://link.getmailspring.com/link/5668E2C6-02CF-4E96-96FA-160F5C615C6F@getmailspring.com/2?redirect=https%3A%2F%2Fbreautek.com&recipient=ZGV2QGNvcmRvdmEuYXBhY2hlLm9yZw%3D%3D)
On Aug 18 2020, at 9:40 am, Chris Brody <ch...@gmail.com> wrote:
> > > The name "draft" for tags in the release process is not that clear to me. I suggest "rc" for release candidate. And yes we should clean these tags up.
>
> -1 on "rc" on my part. I have seen other projects use "rc" to mean an
> rc version that comes before a stable version.
>
> > During the vote, people can append which tag name they prefer.
> +1
> > Anyways, I don't want this decision and vote to end like last time because of a tag name.
> +1 (+100)
> > > I am not sure about removing all tags without the rel prefix and not creating these anymore. These are easy to remember and type tags to get a specific version. Personally I would keep them and create them with the new process after a vote too. "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
> >
> > I am trying to clean up the repos as well. Keep draft tags are not idea IMO. Some repos have 141 tags and half of those are most likely the draft tags which has a corresponding rel tag with identical commit ids.
>
> I would favor keeping both `x.x.x` and `rel/x.x.x` tags for the
> existing releases that were not rejected.
>
> > > "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
> +1.
> Am I right that with this proposal, we would not need to make
> `rel/x.x.x` tags for accepted releases after this proposal is
> accepted?
>
> > I am not looking to remove the `rel/` tag process. That must remain and those tags will remain.
> +1
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Chris Brody <ch...@gmail.com>.
> > The name "draft" for tags in the release process is not that clear to me. I suggest "rc" for release candidate. And yes we should clean these tags up.
-1 on "rc" on my part. I have seen other projects use "rc" to mean an
rc version that comes before a stable version.
> During the vote, people can append which tag name they prefer.
+1
> Anyways, I don't want this decision and vote to end like last time because of a tag name.
+1 (+100)
> > I am not sure about removing all tags without the rel prefix and not creating these anymore. These are easy to remember and type tags to get a specific version. Personally I would keep them and create them with the new process after a vote too. "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
>
> I am trying to clean up the repos as well. Keep draft tags are not idea IMO. Some repos have 141 tags and half of those are most likely the draft tags which has a corresponding rel tag with identical commit ids.
I would favor keeping both `x.x.x` and `rel/x.x.x` tags for the
existing releases that were not rejected.
> > "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
+1.
Am I right that with this proposal, we would not need to make
`rel/x.x.x` tags for accepted releases after this proposal is
accepted?
> I am not looking to remove the `rel/` tag process. That must remain and those tags will remain.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Bryan Ellis <el...@gmail.com>.
> The name "draft" for tags in the release process is not that clear to me. I suggest "rc" for release candidate. And yes we should clean these tags up.
The naming is not what is important, it is the idea.
Since last time I think this topic died because people couldn’t decide on a naming convention, I am setting a hard rule for this vote so it can process accordingly with no blocks.
During the vote, people can append which tag name they prefer. The tag with most points will be used, the default fallback will be `draft/`, and if no tag is provided during the vote, default will be used.
For example vote scenario:
Vote Scenario 1:
+1 rc
+1 draft
+1 temp
`draft/` will be used.
Vote Scenario 2:
+1 rc
+1 draft
+1 rc
`rc/` will be used.
Vote Scenario 3:
+1
+1 draft
+1 rc
`draft/` will be used.
Anyways, I don't want this decision and vote to end like last time because of a tag name.
> I am not sure about removing all tags without the rel prefix and not creating these anymore. These are easy to remember and type tags to get a specific version. Personally I would keep them and create them with the new process after a vote too. "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
I am trying to clean up the repos as well. Keep draft tags are not idea IMO. Some repos have 141 tags and half of those are most likely the draft tags which has a corresponding rel tag with identical commit ids.
> "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
I am not looking to remove the `rel/` tag process. That must remain and those tags will remain.
> On Aug 18, 2020, at 15:48, Niklas Merz <ni...@apache.org> wrote:
>
> I agree that our current process creates confusion in the community.
>
> The name "draft" for tags in the release process is not that clear to me. I suggest "rc" for release candidate. And yes we should clean these tags up.
>
> I am not sure about removing all tags without the rel prefix and not creating these anymore. These are easy to remember and type tags to get a specific version. Personally I would keep them and create them with the new process after a vote too. "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
>
>
> August 18, 2020 8:39 AM, "Bryan Ellis" <er...@apache.org> wrote:
>
>> This discussion is to update our release process, potentially improve community understanding, and
>> as well cleaning up after a successful or failed release.
>> I want the following rules to be implemented and will start the vote after keeping this discussion
>> open within 24 hours for any modifications, suggestions, feedback, or additions.
>>
>> 1. Prefix our draft tags with `draft/`
>>
>> Currently, all of our draft tags, used for release, do not contain any prefix and shows only a
>> version number.
>> It appears this creates confusion within the community. Too many people always ask, "Why is the
>> version not released in npm". I have always noticed these questions only when the draft tag exists.
>> I am hoping that this addition to the release process will help reduce some of the confusion.
>>
>> 2. After a successful or failed vote, remove the `draft/` tag
>>
>> IMO, keeping the draft tag is not necessary. It is supposed to be a temporary tag used only during
>> the voting process.
>> To reduce the clutter in our GH repos, it would be nice to remove these draft tags.
>>
>> If anyone is relying upon a draft tag in a production environment, the usage was their own risk.
>>
>> Also, with the addition of the two rules above, I will append to the vote as well the cleanup
>> request to remove all current existing draft tags from all of our repos. Only tags that have a
>> `rel` tag will be removed.
>> For example, if there is a tag `1.0.0` and `rel/1.0.0`, then tag `1.0.0` will be removed.
>> If there is a tag that doesn’t have a `rel` tag, it will not be deleted and a future email will be
>> created to discuss these unknown tags to figure out what action to be performed.
>>
>> We had this discussion before but never started a vote thread. I will be creating that thread
>> shortly.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
Re: [DISCUSS] Draft Tags & After Release Cleanup
Posted by Niklas Merz <ni...@apache.org>.
I agree that our current process creates confusion in the community.
The name "draft" for tags in the release process is not that clear to me. I suggest "rc" for release candidate. And yes we should clean these tags up.
I am not sure about removing all tags without the rel prefix and not creating these anymore. These are easy to remember and type tags to get a specific version. Personally I would keep them and create them with the new process after a vote too. "rel/x.x.x" are used for the Apache archiving but I like the cleaner tags for users.
August 18, 2020 8:39 AM, "Bryan Ellis" <er...@apache.org> wrote:
> This discussion is to update our release process, potentially improve community understanding, and
> as well cleaning up after a successful or failed release.
> I want the following rules to be implemented and will start the vote after keeping this discussion
> open within 24 hours for any modifications, suggestions, feedback, or additions.
>
> 1. Prefix our draft tags with `draft/`
>
> Currently, all of our draft tags, used for release, do not contain any prefix and shows only a
> version number.
> It appears this creates confusion within the community. Too many people always ask, "Why is the
> version not released in npm". I have always noticed these questions only when the draft tag exists.
> I am hoping that this addition to the release process will help reduce some of the confusion.
>
> 2. After a successful or failed vote, remove the `draft/` tag
>
> IMO, keeping the draft tag is not necessary. It is supposed to be a temporary tag used only during
> the voting process.
> To reduce the clutter in our GH repos, it would be nice to remove these draft tags.
>
> If anyone is relying upon a draft tag in a production environment, the usage was their own risk.
>
> Also, with the addition of the two rules above, I will append to the vote as well the cleanup
> request to remove all current existing draft tags from all of our repos. Only tags that have a
> `rel` tag will be removed.
> For example, if there is a tag `1.0.0` and `rel/1.0.0`, then tag `1.0.0` will be removed.
> If there is a tag that doesn’t have a `rel` tag, it will not be deleted and a future email will be
> created to discuss these unknown tags to figure out what action to be performed.
>
> We had this discussion before but never started a vote thread. I will be creating that thread
> shortly.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org