You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/01/11 22:10:48 UTC

[GitHub] flink pull request #3096: [FLINK-5461] [gelly] Remove Superflous TypeInforma...

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3096

    [FLINK-5461] [gelly] Remove Superflous TypeInformation Declaration

    FLINK-4624 updated Gelly's Summarization algorithm to use Either<NullValue, VV> in order to support types for which the serialization does not support null values. This required the use of explicit TypeInformation due to TypeExtractor. FLINK-4673 created a TypeInfoFactory for EitherType so the explicit TypeInformation can be removed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 5461_remove_superflous_typeinformation_declaration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3096
    
----
commit 55ae204beb013fe567ee427265d4b0400f96447e
Author: Greg Hogan <co...@greghogan.com>
Date:   2017-01-11T18:43:58Z

    [FLINK-5461] [gelly] Remove Superflous TypeInformation Declaration
    
    FLINK-4624 updated Gelly's Summarization algorithm to use
    Either<NullValue, VV> in order to support types for which the
    serialization does not support null values. This required the use of
    explicit TypeInformation due to TypeExtractor. FLINK-4673 created a
    TypeInfoFactory for EitherType so the explicit TypeInformation can be
    removed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3096: [FLINK-5461] [gelly] Remove Superflous TypeInformation De...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3096
  
    Looks good, thanks.
    
    +1 to merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3096: [FLINK-5461] [gelly] Remove Superflous TypeInforma...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3096


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---