You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/14 22:31:15 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
zrhoffman opened a new pull request, #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
As noted in #6963, as of #6569, `POST /api/3.1/servers` and `PUT /api/3.1/servers` can no longer change `updPending`. In the Ansible Roles, this breaks deploying Grove, as Grove will not generate `/etc/grove/remap.json` if updates are not pending for that server.
This PR queues updates on Caches in all CDNs after performing snapshots at the end of the Dataset Loader.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Automation - Ansible Roles<!-- Please specify which (GitHub Actions, Docker images, Ansible Roles, etc.) -->
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Test Dataset Loader, verify updates are queued for all Caches
## PR submission checklist
- [ ] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a merged pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
jhg03a merged PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965#discussion_r922301556
##########
infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml:
##########
@@ -1043,3 +1043,18 @@
delay: 10
vars:
error_query: "alerts[?level=='error'].text[?!contains(@,'already exists')]"
+
+- name: Queue Caches in all CDNs
+ uri:
+ url: "{{ dl_to_url }}/api/{{ dl_to_api_version }}/cdns/{{ item.id }}/queue_update"
+ method: POST
+ body:
+ action: "queue"
+ with_items: "{{ get_all_cdns.json.response[1:] }}"
Review Comment:
> because the order of the json isn't guaranteed.
Also, the sort order is always the same
https://github.com/apache/trafficcontrol/blob/19f3b2eafde573546221e767c77f283994fb2fa7/traffic_ops/traffic_ops_golang/cdn/cdns.go#L139-L140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965#discussion_r922301556
##########
infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml:
##########
@@ -1043,3 +1043,18 @@
delay: 10
vars:
error_query: "alerts[?level=='error'].text[?!contains(@,'already exists')]"
+
+- name: Queue Caches in all CDNs
+ uri:
+ url: "{{ dl_to_url }}/api/{{ dl_to_api_version }}/cdns/{{ item.id }}/queue_update"
+ method: POST
+ body:
+ action: "queue"
+ with_items: "{{ get_all_cdns.json.response[1:] }}"
Review Comment:
> because the order of the json isn't guaranteed.
Also, the sort order is always the same
https://github.com/apache/trafficcontrol/blob/19f3b2eafde573546221e767c77f283994fb2fa7/traffic_ops/traffic_ops_golang/cdn/cdns.go#L140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on a diff in pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
jhg03a commented on code in PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965#discussion_r925814591
##########
infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml:
##########
@@ -1043,3 +1043,18 @@
delay: 10
vars:
error_query: "alerts[?level=='error'].text[?!contains(@,'already exists')]"
+
+- name: Queue Caches in all CDNs
+ uri:
+ url: "{{ dl_to_url }}/api/{{ dl_to_api_version }}/cdns/{{ item.id }}/queue_update"
+ method: POST
+ body:
+ action: "queue"
+ with_items: "{{ get_all_cdns.json.response[1:] }}"
Review Comment:
Ok, so even if json itself isn't we're coercing it to be. It's still a bug laying in wait should you name a CDN something alphabetically before ALL. If we want to merge this and open more issues to fix that separately that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965#discussion_r921632183
##########
infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml:
##########
@@ -1043,3 +1043,18 @@
delay: 10
vars:
error_query: "alerts[?level=='error'].text[?!contains(@,'already exists')]"
+
+- name: Queue Caches in all CDNs
+ uri:
+ url: "{{ dl_to_url }}/api/{{ dl_to_api_version }}/cdns/{{ item.id }}/queue_update"
+ method: POST
+ body:
+ action: "queue"
+ with_items: "{{ get_all_cdns.json.response[1:] }}"
Review Comment:
The previous task, *Snapshot all CDNs*, uses this method to exclude the *ALL* CDN
https://github.com/apache/trafficcontrol/blob/a0fbd63083140e64d35d886e0cc87cc8b542aaa6/infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml#L1034-L1038
Maybe someone else can add `json_query` to both tasks in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on code in PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965#discussion_r921633594
##########
infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml:
##########
@@ -1043,3 +1043,18 @@
delay: 10
vars:
error_query: "alerts[?level=='error'].text[?!contains(@,'already exists')]"
+
+- name: Queue Caches in all CDNs
+ uri:
+ url: "{{ dl_to_url }}/api/{{ dl_to_api_version }}/cdns/{{ item.id }}/queue_update"
+ method: POST
+ body:
+ action: "queue"
+ with_items: "{{ get_all_cdns.json.response[1:] }}"
Review Comment:
I don't think that both tasks should use different methods for filtering out the *ALL* CDN, though, and changing the *Snapshot all CDNs* task is outside the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on a diff in pull request #6965: Ansible Dataset Loader: Queue Caches after performing Snapshots
Posted by GitBox <gi...@apache.org>.
jhg03a commented on code in PR #6965:
URL: https://github.com/apache/trafficcontrol/pull/6965#discussion_r921630082
##########
infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml:
##########
@@ -1043,3 +1043,18 @@
delay: 10
vars:
error_query: "alerts[?level=='error'].text[?!contains(@,'already exists')]"
+
+- name: Queue Caches in all CDNs
+ uri:
+ url: "{{ dl_to_url }}/api/{{ dl_to_api_version }}/cdns/{{ item.id }}/queue_update"
+ method: POST
+ body:
+ action: "queue"
+ with_items: "{{ get_all_cdns.json.response[1:] }}"
Review Comment:
This should use a different method like json_query to exclude the ALL CDN because the order of the json isn't guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org