Re: svn commit: r1818007 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/util/string: FlexibleStringExpander.java JuelConnector.java UelFunctions.java UelUtil.java

[Nicolas Malin <ni...@nereide.fr>]

Oh I missed your issue Jacques, thanks for catching theses commits and 
updating it.

Nicolas


Le 17/12/2017 à 22:40, Jacques Le Roux a écrit :
> Thanks guys, this fixed OFBIZ-10058
>
> Jacques
>
>
> Le 17/12/2017 à 21:06, Michael Brohl a écrit :
>> Hi Nicolas,
>>
>> great, seems I missed the 2nd similar code block. I saw too much code 
>> in the recent days... ;-)
>>
>> Thanks for taking care,
>>
>> regards,
>>
>> Michael
>>
>>
>> Am 17.12.17 um 21:02 schrieb Nicolas Malin:
>>> Thanks Michael
>>>
>>> I applied the same correction on the second one at 1818510.
>>>
>>> Thanks for the works !
>>>
>>> Cheers,
>>>
>>> Nicolas
>>>
>>>
>>> Le 17/12/2017 à 19:10, Michael Brohl a écrit :
>>>> Hi Nicolas,
>>>>
>>>> thanks for reporting!
>>>>
>>>> I guess that this is the reason why there was no logging at all. At 
>>>> r1818498 I added verbose logging.
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>> Am 17.12.17 um 18:00 schrieb Nicolas Malin:
>>>>> Hello Michael,
>>>>>
>>>>> Le 13/12/2017 à 14:03, mbrohl@apache.org a écrit :
>>>>>> --- 
>>>>>> ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
>>>>>> (original)
>>>>>> +++ 
>>>>>> ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/string/JuelConnector.java 
>>>>>> Wed Dec 13 13:03:03 2017
>>>>>> @@ -78,7 +78,9 @@ public class JuelConnector {
>>>>>>               Object base = null;
>>>>>>               try {
>>>>>>                   base = prefix.eval(bindings, context);
>>>>>> -            } catch (Exception e) {}
>>>>>> +            } catch (Exception e) {
>>>>>> +                Debug.log(e, module);
>>>>>> +            }
>>>>>
>>>>> With this commit, my logs are now massively populate by
>>>>>
>>>>> 2017-12-17 17:32:52,542 |main |JuelConnector |F| null
>>>>> javax.el.PropertyNotFoundException: Cannot resolve identifier 
>>>>> 'updateServiceCtx'
>>>>>         at 
>>>>> de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93) 
>>>>> ~[juel-impl-2.2.7.jar:2.2.7]
>>>>>         at 
>>>>> org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116) 
>>>>> [ofbiz.jar:?]
>>>>>         ...
>>>>>
>>>>> I'm alone on this case ?
>>>>> I propose, if you want display the exception, to replace all 
>>>>> Debug.log(e, module); by
>>>>> if (Debug.verboseOn()) {Debug.logVerbose("failed to .... by " 
>>>>> e.toString(), module); }
>>>>>
>>>>> Like this we can display them without stacktrace when the verbose 
>>>>> mode will be enable.
>>>>>
>>>>> Cheers,
>>>>> Nicolas
>>>>
>>>
>>
>
>