[GitHub] [kafka] fvaleri commented on a diff in pull request #13738: KAFKA-14982: Improve the kafka-metadata-quorum output

["fvaleri (via GitHub)" <gi...@apache.org>]

fvaleri commented on code in PR #13738:
URL: https://github.com/apache/kafka/pull/13738#discussion_r1200336739


##########
tools/src/main/java/org/apache/kafka/tools/MetadataQuorumCommand.java:
##########
@@ -136,17 +143,21 @@ private static void addDescribeParser(Subparsers subparsers) {
             .addArgument("--replication")
             .help("Detailed information about the status of replication")
             .action(Arguments.storeTrue());
+        replicationArgs
+            .addArgument("-hr", "--human-readable")

Review Comment:
   It doesn't work with --status, but I see what you mean. We should raise an error, rather than silently ignore the --hr option.



##########
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##########
@@ -172,4 +173,34 @@ public void testDescribeQuorumInZkMode() {
         );
 
     }
+
+    @ClusterTests({
+        @ClusterTest(clusterType = Type.CO_KRAFT, brokers = 1, controllers = 1),
+    })
+    public void testHumanReadableTimestamps() {
+        String replicationOutput0 = ToolsTestUtils.captureStandardOut(() ->

Review Comment:
   Yes, this is related to the above. Will do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org