You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Ranxy (via GitHub)" <gi...@apache.org> on 2023/08/01 14:06:39 UTC

[GitHub] [incubator-opendal] Ranxy opened a new pull request, #2757: Ocaml binding

Ranxy opened a new pull request, #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757

   ref #2756 
   
   Added a simple OCaml binding to implement the blocking operator.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Ranxy commented on pull request #2757: Ocaml binding

Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1662134941

   > In order to package this project with ocaml's package manager opam, it seems that the files `bindings/ocaml/dune-project` and `bindings/ocaml/opendal.opam` need to be moved to the top level directory of the project. Will this be a problem?
   
   This is because opam will take the directory of dune-project as the root directory of the project, and copy this directory to a separate directory for compilation and packaging. If `dune-project` is in `bindings/ocaml`, then it cannot be built after copying this directory alone. Because this is part of the entire workspace in the rust project and cannot be compiled separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] oowl commented on pull request #2757: Ocaml binding

Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1660568621

   > It seems that `ocaml/setup-ocaml@v2` cannot be used directly in CI
   
   Maybe it's related to https://github.com/apache/incubator-opendal/pull/2693#issuecomment-1646820203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo merged pull request #2757: feat: Add OCaml Binding

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2757: Ocaml binding

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1660464173

   Woooooooooooow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Ranxy commented on pull request #2757: Ocaml binding

Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1660545774

   It seems that `ocaml/setup-ocaml@v2` cannot be used directly in CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2757: Ocaml binding

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#discussion_r1283907990


##########
.github/workflows/ci.yml:
##########
@@ -75,6 +75,16 @@ jobs:
           distribution: temurin
           java-version: "11"
 
+      - name: Checkout ocaml env

Review Comment:
   How about add a `Setup OCaml toolchain` like rust under `.github/actions/setup_ocaml`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Ranxy commented on pull request #2757: feat: Add OCaml Binding

Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1664945635

   > Great, mostly LGTM!
   > 
   > Would you like to start a tracking issue for the future issues of ocaml binding?
   
   Of course it's exciting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2757: Ocaml binding

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1661413482

   As mentioned by @oowl, we require approval from ASF Infra for this action. The action appears to be maintained by ocaml.org, which is a trustworthy source. I have submitted a ticket at https://issues.apache.org/jira/browse/INFRA-24856 and now we need to wait for their response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2757: Ocaml binding

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1663731102

   Hi, setup-ocaml has been approved. Please add some new commits to have a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2757: feat: Add OCaml Binding

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#discussion_r1283928825


##########
.github/workflows/ci.yml:
##########
@@ -75,6 +75,12 @@ jobs:
           distribution: temurin
           java-version: "11"
 
+      - name: Setup OCaml toolchain
+        uses: ./.github/actions/setup-ocaml
+        with:
+          need-depext: false

Review Comment:
   We can leave `false` as default value so that we don't need to repeat.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Ranxy commented on a diff in pull request #2757: Ocaml binding

Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on code in PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#discussion_r1283912696


##########
.github/workflows/ci.yml:
##########
@@ -75,6 +75,16 @@ jobs:
           distribution: temurin
           java-version: "11"
 
+      - name: Checkout ocaml env

Review Comment:
   good idea, i'll try it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Ranxy commented on pull request #2757: Ocaml binding

Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #2757:
URL: https://github.com/apache/incubator-opendal/pull/2757#issuecomment-1662125989

   In order to package this project with ocaml's package manager opam, it seems that the files `bindings/ocaml/dune-project` and `bindings/ocaml/opendal.opam` need to be moved to the top level directory of the project. Will this be a problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org