You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/10/07 16:27:07 UTC

[GitHub] [accumulo] ctubbsii commented on issue #1659: Handle Internal pluggable components

ctubbsii commented on issue #1659:
URL: https://github.com/apache/accumulo/issues/1659#issuecomment-705050279


   > @ctubbsii what are your thoughts on moving the VolumeChoser to SPI?  At first glance it doesn't look like there are any offending types across the interfaces, so it may just be a matter of relocation.  Since the VolumeChoser doesn't directly affect user data (just where the data is stored) then it seems like the SPI is a more appropriate place.
   
   I'm in favor, but would want to review it's methods to be sure there's nothing we should polish first. Right now, it might be a bit Stringly typed, and we might want to consider using a proper 'Volume' type.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org