You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/08/18 14:46:59 UTC
[PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
andygrove opened a new pull request, #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#issuecomment-3207091305
@parthchandra could you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#discussion_r2283621119
##########
native/core/src/execution/jni_api.rs:
##########
@@ -173,12 +175,22 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_createPlan(
let start = Instant::now();
+ // Deserialize query plan
let array = unsafe { JPrimitiveArray::from_raw(serialized_query) };
let bytes = env.convert_byte_array(array)?;
-
- // Deserialize query plan
let spark_plan = serde::deserialize_op(bytes.as_slice())?;
+ // Deserialize Spark configs
+ let array = unsafe { JPrimitiveArray::from_raw(serialized_spark_configs) };
+ let bytes = env.convert_byte_array(array)?;
+ let spark_configs = serde::deserialize_config(bytes.as_slice())?;
+
+ // Convert Spark configs to HashMap
+ let _spark_config_map: HashMap<String, String> = spark_configs
Review Comment:
Oh, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#discussion_r2283573982
##########
native/core/src/execution/jni_api.rs:
##########
@@ -173,12 +175,22 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_createPlan(
let start = Instant::now();
+ // Deserialize query plan
let array = unsafe { JPrimitiveArray::from_raw(serialized_query) };
let bytes = env.convert_byte_array(array)?;
-
- // Deserialize query plan
let spark_plan = serde::deserialize_op(bytes.as_slice())?;
+ // Deserialize Spark configs
+ let array = unsafe { JPrimitiveArray::from_raw(serialized_spark_configs) };
+ let bytes = env.convert_byte_array(array)?;
+ let spark_configs = serde::deserialize_config(bytes.as_slice())?;
+
+ // Convert Spark configs to HashMap
+ let _spark_config_map: HashMap<String, String> = spark_configs
Review Comment:
Yes, this is the code for deserializing the protobuf `map` type. The hash map is not used yet, hence the variable name starting with `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#discussion_r2283532114
##########
native/proto/src/proto/config.proto:
##########
@@ -0,0 +1,31 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+syntax = "proto3";
+
+package spark.spark_config;
+
+option java_package = "org.apache.comet.serde";
+
+message ConfigMap {
+ repeated ConfigEntry entry = 1;
+}
+
+message ConfigEntry {
Review Comment:
object_store_options does follow a similar approach, only the proto uses a `map` type directly, which I did not know was supported. I will update this PR to use the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#discussion_r2283471411
##########
native/proto/src/proto/config.proto:
##########
@@ -0,0 +1,31 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+syntax = "proto3";
+
+package spark.spark_config;
+
+option java_package = "org.apache.comet.serde";
+
+message ConfigMap {
+ repeated ConfigEntry entry = 1;
+}
+
+message ConfigEntry {
Review Comment:
We already had something similar for datafusion scan. https://github.com/apache/datafusion-comet/blob/0771de6cdc1c466864d7e8aa1da06b298f1c04cb/native/proto/src/proto/operator.proto#L103
Maybe we can consolidate the two approaches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#issuecomment-3197419534
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2180?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `80.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 34.82%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7880232`](https://app.codecov.io/gh/apache/datafusion-comet/commit/7880232b2a52804ef2052e071d7e9274cdfe5aeb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 388 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/2180?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/scala/org/apache/comet/CometExecIterator.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2180?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2FCometExecIterator.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9Db21ldEV4ZWNJdGVyYXRvci5zY2FsYQ==) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2180 +/- ##
=============================================
- Coverage 56.12% 34.82% -21.31%
+ Complexity 976 860 -116
=============================================
Files 119 143 +24
Lines 11743 13195 +1452
Branches 2251 2351 +100
=============================================
- Hits 6591 4595 -1996
- Misses 4012 7693 +3681
+ Partials 1140 907 -233
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2180?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180#discussion_r2283566469
##########
native/core/src/execution/jni_api.rs:
##########
@@ -173,12 +175,22 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_createPlan(
let start = Instant::now();
+ // Deserialize query plan
let array = unsafe { JPrimitiveArray::from_raw(serialized_query) };
let bytes = env.convert_byte_array(array)?;
-
- // Deserialize query plan
let spark_plan = serde::deserialize_op(bytes.as_slice())?;
+ // Deserialize Spark configs
+ let array = unsafe { JPrimitiveArray::from_raw(serialized_spark_configs) };
+ let bytes = env.convert_byte_array(array)?;
+ let spark_configs = serde::deserialize_config(bytes.as_slice())?;
+
+ // Convert Spark configs to HashMap
+ let _spark_config_map: HashMap<String, String> = spark_configs
Review Comment:
Do we need this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Pass Spark configs to native `createPlan` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #2180:
URL: https://github.com/apache/datafusion-comet/pull/2180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org