You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jasonyuan-cn (via GitHub)" <gi...@apache.org> on 2023/05/22 02:26:45 UTC

[GitHub] [flink] jasonyuan-cn opened a new pull request, #22615: fix: analyze.md SQL sample syntax error

jasonyuan-cn opened a new pull request, #22615:
URL: https://github.com/apache/flink/pull/22615

   Fixed the SQL sample syntax error in analyze.md, the comma in the sample SQL should be inside the double quotes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jasonyuan-cn commented on pull request #22615: [hotfix][doc] Fix typo in analyze.md

Posted by "jasonyuan-cn (via GitHub)" <gi...@apache.org>.
jasonyuan-cn commented on PR #22615:
URL: https://github.com/apache/flink/pull/22615#issuecomment-1560523933

   I'm sorry, I'm too unfamiliar with github PRs, I'll close this one just in case, then I'll try to resubmit the PR to fix the typo problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] reswqa commented on pull request #22615: [hotfix][doc] Fix typo in analyze.md - SQL sample syntax error

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22615:
URL: https://github.com/apache/flink/pull/22615#issuecomment-1560379814

   BTW, you should rename your commit titile to `[hotfix][doc] Fix typo in analyze.md`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jasonyuan-cn closed pull request #22615: [hotfix][doc] Fix typo in analyze.md

Posted by "jasonyuan-cn (via GitHub)" <gi...@apache.org>.
jasonyuan-cn closed pull request #22615: [hotfix][doc] Fix typo in analyze.md
URL: https://github.com/apache/flink/pull/22615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] reswqa commented on pull request #22615: [hotfix][doc] Fix typo in analyze.md

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22615:
URL: https://github.com/apache/flink/pull/22615#issuecomment-1560493433

   > BTW, you should rename your commit titile to [hotfix][doc] Fix typo in analyze.md.
   
   Sorry, I may not have expressed myself clearly. What needs to be modified is not only the title of this pull request, but also the title of the commit message. Now it is: [fix: analyze.md SQL syntax error](https://github.com/apache/flink/pull/22615/commits/5e50d9b947ddb87cd8e7e700fce8c8af750ec2b9)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jasonyuan-cn commented on a diff in pull request #22615: [hotfix][doc] Fix typo in analyze.md

Posted by "jasonyuan-cn (via GitHub)" <gi...@apache.org>.
jasonyuan-cn commented on code in PR #22615:
URL: https://github.com/apache/flink/pull/22615#discussion_r1203463401


##########
docs/content/docs/dev/table/sql/analyze.md:
##########
@@ -379,4 +379,4 @@ ANALYZE TABLE [catalog_name.][db_name.]table_name PARTITION(partcol1[=val1] [, p
 
 *NOTE:* For the fix length types (like `BOOLEAN`, `INTEGER`, `DOUBLE` etc.), we need not collect the `avgLen` and `maxLen` from the original records.
 
-{{< top >}}
\ No newline at end of file
+{{< top >}}

Review Comment:
   This line of code should not be changed, sorry for my carelessness. I will undo this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22615: fix: analyze.md SQL sample syntax error

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22615:
URL: https://github.com/apache/flink/pull/22615#issuecomment-1556427001

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5e50d9b947ddb87cd8e7e700fce8c8af750ec2b9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5e50d9b947ddb87cd8e7e700fce8c8af750ec2b9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5e50d9b947ddb87cd8e7e700fce8c8af750ec2b9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] reswqa commented on a diff in pull request #22615: [hotfix][doc] Fix typo in analyze.md - SQL sample syntax error

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #22615:
URL: https://github.com/apache/flink/pull/22615#discussion_r1203329260


##########
docs/content/docs/dev/table/sql/analyze.md:
##########
@@ -81,8 +81,8 @@ tableEnv.executeSql(
         " `id` BIGINT NOT NULl," +
         " `product` VARCHAR(32)," +
         " `amount` INT," +
-        " `sold_year` BIGINT", +
-        " `sold_month` BIGINT", +
+        " `sold_year` BIGINT," +
+        " `sold_month` BIGINT," +

Review Comment:
   Please also check the Chinese document to see if there are any similar issues.



##########
docs/content/docs/dev/table/sql/analyze.md:
##########
@@ -379,4 +379,4 @@ ANALYZE TABLE [catalog_name.][db_name.]table_name PARTITION(partcol1[=val1] [, p
 
 *NOTE:* For the fix length types (like `BOOLEAN`, `INTEGER`, `DOUBLE` etc.), we need not collect the `avgLen` and `maxLen` from the original records.
 
-{{< top >}}
\ No newline at end of file
+{{< top >}}

Review Comment:
   What is the purpose of this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jasonyuan-cn commented on a diff in pull request #22615: [hotfix][doc] Fix typo in analyze.md

Posted by "jasonyuan-cn (via GitHub)" <gi...@apache.org>.
jasonyuan-cn commented on code in PR #22615:
URL: https://github.com/apache/flink/pull/22615#discussion_r1203463737


##########
docs/content/docs/dev/table/sql/analyze.md:
##########
@@ -81,8 +81,8 @@ tableEnv.executeSql(
         " `id` BIGINT NOT NULl," +
         " `product` VARCHAR(32)," +
         " `amount` INT," +
-        " `sold_year` BIGINT", +
-        " `sold_month` BIGINT", +
+        " `sold_year` BIGINT," +
+        " `sold_month` BIGINT," +

Review Comment:
   Thanks for your reply. I will check Chinese document also.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jasonyuan-cn commented on pull request #22615: [hotfix][doc] Fix typo in analyze.md

Posted by "jasonyuan-cn (via GitHub)" <gi...@apache.org>.
jasonyuan-cn commented on PR #22615:
URL: https://github.com/apache/flink/pull/22615#issuecomment-1560508344

   
   
   
   
   > > BTW, you should rename your commit titile to [hotfix][doc] Fix typo in analyze.md.
   > 
   > Sorry, I may not have expressed myself clearly. What needs to be modified is not only the title of this pull request, but also the title of the commit message. Now it is: [fix: analyze.md SQL syntax error](https://github.com/apache/flink/pull/22615/commits/5e50d9b947ddb87cd8e7e700fce8c8af750ec2b9).
   
   Thank you so much for your patience and help. I have learned that. And I am trying to push new commit on this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org