You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/28 22:27:50 UTC
[GitHub] [druid] samarthjain opened a new pull request #9438: Don't exclude
null dimension values from the map based query response
samarthjain opened a new pull request #9438: Don't exclude null dimension values from the map based query response
URL: https://github.com/apache/druid/pull/9438
Fixes #8631
This PR has:
- [X ] been self-reviewed.
- [X] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [X ] added unit tests or modified existing tests to cover new code paths.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* ResultRow.java
* ResultRowTest.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #9438: Don't exclude null
dimension values from the map based query response
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #9438: Don't exclude null dimension values from the map based query response
URL: https://github.com/apache/druid/pull/9438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] samarthjain commented on issue #9438: Don't exclude null
dimension values from the map based query response
Posted by GitBox <gi...@apache.org>.
samarthjain commented on issue #9438: Don't exclude null dimension values from the map based query response
URL: https://github.com/apache/druid/pull/9438#issuecomment-593585652
@gianm - does this look good to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org